Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236626: Update copyright header for files modified in 2019 #76

Closed

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 3, 2020

Simple fix to update the copyright year in the one file that was changed in 2019 after the last update of the year.

@arapte can you please review?

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8236626: Update copyright header for files modified in 2019

Approvers

  • Ambarish Rapte (arapte - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Jan 3, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 3, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2020

Webrevs

@arapte
arapte approved these changes Jan 3, 2020
Copy link

arapte left a comment

looks good to me.

@openjdk openjdk bot removed the rfr label Jan 3, 2020
@openjdk
Copy link

openjdk bot commented Jan 3, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8236626: Update copyright header for files modified in 2019

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.
    ➡️ To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jan 3, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 3, 2020

/integrate

@openjdk openjdk bot closed this Jan 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 3, 2020
@openjdk
Copy link

openjdk bot commented Jan 3, 2020

@kevinrushforth
Pushed as commit 3c4d68d.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8236626-copyr-2019 branch Jan 4, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: 3c4d68d
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-03 13:04:04 +0000
URL: https://git.openjdk.java.net/jfx/commit/3c4d68dc

8236626: Update copyright header for files modified in 2019

Reviewed-by: arapte

! modules/javafx.graphics/src/test/java/test/javafx/scene/text/Text_cssMethods_Test.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.