8283328: Update libxml2 to 2.9.13

[HimaBinduMeda]

We currently use libxml2 version 2.9.12. It should be updated to latest stable release, which is version 2.9.13.
The steps to update libxml are documented in UPDATING.txt.
There is compilation issue with the release 2.9.13, as mentioned here: https://gitlab.gnome.org/GNOME/libxml2/-/issues/349.
Updated the code with the changes as per the fix mentioned in above link.

Compiled and verified on Windows, Mac and Linux platforms.
Sanity testing looks fine.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283328: Update libxml2 to 2.9.13

Reviewers

• Johan Vos (@johanvos - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/764/head:pull/764
$ git checkout pull/764

Update a local copy of the PR:
$ git checkout pull/764
$ git pull https://git.openjdk.java.net/jfx pull/764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 764

View PR using the GUI difftool:
$ git pr show -t 764

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/764.diff

[bridgekeeper]

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[kevinrushforth]

I'll do testing and a sanity check review tomorrow. Here are three meta issues:

1. As noted in SKARA-1222, your patch introduces a sym-link that is causing jcheck to throw an exception. Given that we do not want any sym-links in the repo anyway, you will need to revert the file in question.
2. Once the above is fixed, you will note that jcheck reports some whitespace errors.
3. You need to update the version in libxml2.md.

[kevinrushforth]

4. I see that the following files were deleted as part of this PR. Was this intentional?

D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/AUTHORS
D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/ChangeLog
D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/README

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with 1 of role reviewers, 1 of role authors).

[mlbridge]

Webrevs

• 01: Full - Incremental (92ba9af0)
• 00: Full (8dca3c2e)

[johanvos]

This looks good. Just for my understanding: this is the 2.9.13-tagged plus the fix for the issue with xmlValidNormalizeString() with --without-valid-build (https://gitlab.gnome.org/GNOME/libxml2/-/commit/d05317cee5eb2bd35269b7706a8850c6c3097de3) ?
I notice there was a followup patch (https://gitlab.gnome.org/GNOME/libxml2/-/commit/b057239b3f65c8dd9d472fc878214ea4b1d852d3) but that doesn't touch files we have, and since builds are compiling for me, it seems that we are all good now.

[HimaBinduMeda]

1. As noted in SKARA-1222, your patch introduces a sym-link that is causing jcheck to throw an exception. Given that we do not want any sym-links in the repo anyway, you will need to revert the file in question.

--- Fixed symlinks issue by reverting the file

2. Once the above is fixed, you will note that jcheck reports some whitespace errors.

-- Resolved

3. You need to update the version in libxml2.md.

-- Updated

[HimaBinduMeda]

This looks good. Just for my understanding: this is the 2.9.13-tagged plus the fix for the issue with xmlValidNormalizeString() with --without-valid-build (https://gitlab.gnome.org/GNOME/libxml2/-/commit/d05317cee5eb2bd35269b7706a8850c6c3097de3) ?

-- Yes, just this patch is sufficient to resolve compilation error.

I notice there was a followup patch (https://gitlab.gnome.org/GNOME/libxml2/-/commit/b057239b3f65c8dd9d472fc878214ea4b1d852d3) but that doesn't touch files we have, and since builds are compiling for me, it seems that we are all good now.

-- Yes , the followup patch is not needed.

[johanvos]

Looks good and works fine on Mac/Linux/Windows

[HimaBinduMeda]

7. I see that the following files were deleted as part of this PR. Was this intentional?

D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/AUTHORS
D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/ChangeLog
D       modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/README

-- The above files have been deleted in the release v2.9.13.
Added README.md which contains information regarding Authors,License and libxml project

[kevinrushforth]

Looks good. Tested on all three platforms.

[openjdk]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283328: Update libxml2 to 2.9.13

Reviewed-by: jvos, kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• cff84e2: 8283509: Invisible menus can lead to IndexOutOfBoundsException
• a0db473: 8280369: native library cache should be platform/arch specific
• d1fb3d3: 8283517: Update boot JDK to 18
• 424aeba: 8277309: Add support for H.265/HEVC to HTTP Live Streaming
• eb7fa5d: 8270867: Debug build of WebKit 613.1 fails on Linux
• ff75917: 8283183: Skip failing PredefinedMeshManagerTest tests
• 4afc8af: Merge
• df43d2b: 8282766: Create release notes for JavaFX 18
• d28f3d7: 8282093: LineChart path incorrect when outside lower bound
• c6069d6: 8271054: [REDO] Wrong stage gets focused after modal stage creation
• ... and 5 more: https://git.openjdk.java.net/jfx/compare/2e8a4a5e97bb88a5807ae5fe075b98e1d54a4ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos, @kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[arapte]

Looks good, tested Mac M1 build and macos sanity check.

[HimaBinduMeda]

/integrate

[openjdk]

@HimaBinduMeda
Your change (at version 92ba9af) is now ready to be sponsored by a Committer.

[arapte]

/sponsor

[openjdk]

Going to push as commit b0f2521.
Since your change was applied there have been 15 commits pushed to the master branch:

• cff84e2: 8283509: Invisible menus can lead to IndexOutOfBoundsException
• a0db473: 8280369: native library cache should be platform/arch specific
• d1fb3d3: 8283517: Update boot JDK to 18
• 424aeba: 8277309: Add support for H.265/HEVC to HTTP Live Streaming
• eb7fa5d: 8270867: Debug build of WebKit 613.1 fails on Linux
• ff75917: 8283183: Skip failing PredefinedMeshManagerTest tests
• 4afc8af: Merge
• df43d2b: 8282766: Create release notes for JavaFX 18
• d28f3d7: 8282093: LineChart path incorrect when outside lower bound
• c6069d6: 8271054: [REDO] Wrong stage gets focused after modal stage creation
• ... and 5 more: https://git.openjdk.java.net/jfx/compare/2e8a4a5e97bb88a5807ae5fe075b98e1d54a4ca0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@arapte @HimaBinduMeda Pushed as commit b0f2521.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.