-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283218: Update GStreamer to 1.20.1 #768
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
/solves 8283403: Update Glib to 2.72.0 |
@sashamatveev |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
This still uses the system Glib library on Linux, right? What Linux platforms have you tried this on? It fails for me on my local Ubuntu 16.04 system.
We compile with |
The updated version gets past the earlier error, but still fails:
|
Update GStreamer to 1.20.1 [v2]
Update GStreamer to 1.20.1 [v3]
|
I see one remaining build failure on Ubuntu 16.04, which should be easy to fix:
The workaround you needed to do this time suggests we will need a different approach for the next update. I think we will need to consider one of two things:
We can decide as it gets closer to the next update. |
8283218: Update GStreamer to 1.20.1 [v4]
|
8283218: Update GStreamer to 1.20.1 [v5]
|
The latest patch builds and runs for me now on Ubuntu 16.04. I do want to make sure that regardless of whatever system we build it on, the binary is able to run on the oldest version we are targeting. Otherwise, a binary built on, say, Oracle Linux 7.x or Ubuntu 20.04 might not run on an Ubuntu 16.04 system. Basically what we don't want is to be dependent on a particular version of libraries at compile time. The more I think about it, the best long term solution (not this time) is probably to build and deliver glib-lite.so on Linux. |
I have this working on Ubuntu 18.04, and that gives me enough confidence that with the appropriate toolchain it can be built for 16.04. Exploring glib-lite.so sounds like a good plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering my own question from above, I was able to take a gstreamer-lite
binary built on Oracle Linux 7.x and run it on my Ubuntu 16.04 system, so it looks like we are good to go.
Alexander or I will file a follow-on bug to build and ship glib-lite
on Linux. It will allow some of the custom code to be reverted, and will avoid this problem the next time we update GLib. It also matches what we do for the other platforms (and what we do for Linux on Oracle's JDK 8u releases, so we have a data point that shows it to be a feasible approach).
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit c4b1a72.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit c4b1a72. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/768/head:pull/768
$ git checkout pull/768
Update a local copy of the PR:
$ git checkout pull/768
$ git pull https://git.openjdk.java.net/jfx pull/768/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 768
View PR using the GUI difftool:
$ git pr show -t 768
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/768.diff