Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278980: Update WebKit to 613.1 #770

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 13, 2022

Co-authored-by: Ajit Ghaisas aghaisas@openjdk.org
Co-authored-by: Jay Bhaskar jay.bhaskar@oracle.com
Co-authored-by: Kevin Rushforth kcr@openjdk.org
Reviewed-by: kcr, jvos, aghaisas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/770/head:pull/770
$ git checkout pull/770

Update a local copy of the PR:
$ git checkout pull/770
$ git pull https://git.openjdk.java.net/jfx pull/770/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 770

View PR using the GUI difftool:
$ git pr show -t 770

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/770.diff

Co-authored-by: Ajit Ghaisas <aghaisas@openjdk.org>
Co-authored-by: Jay Bhaskar <jay.bhaskar@oracle.com>
Co-authored-by: Kevin Rushforth <kcr@openjdk.org>
Reviewed-by: kcr, jvos, aghaisas
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx18 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6f28d912024495278c4c35ab054bc2aab480b3e4 8278980: Update WebKit to 613.1 Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Ready for review labels Apr 13, 2022
@kevinrushforth
Copy link
Member

I can confirm that this is a clean patch, even though Skara doesn't record it as clean -- see SKARA-1332.

/clean

@openjdk openjdk bot added the clean label Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@kevinrushforth This backport pull request is now marked as clean

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278980: Update WebKit to 613.1

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx18 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx18 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 13, 2022
@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit f19b57a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2022
@openjdk openjdk bot closed this Apr 13, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@johanvos Pushed as commit f19b57a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants