Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281459: WebKit 613.1 build broken on M1 #771

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 13, 2022

Reviewed-by: kcr, jvos


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/771/head:pull/771
$ git checkout pull/771

Update a local copy of the PR:
$ git checkout pull/771
$ git pull https://git.openjdk.java.net/jfx pull/771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 771

View PR using the GUI difftool:
$ git pr show -t 771

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/771.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx18 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cdebc6cbafb579148b4addee44d307bd9739454b 8281459: WebKit 613.1 build broken on M1 Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281459: WebKit 613.1 build broken on M1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx18 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx18 branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Apr 13, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit 66661d7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2022
@openjdk openjdk bot closed this Apr 13, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@johanvos Pushed as commit 66661d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants