Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285475: Create release notes for 18.0.1 #785

Closed
wants to merge 2 commits into from

Conversation

abhinayagarwal
Copy link
Contributor

@abhinayagarwal abhinayagarwal commented Apr 25, 2022

Add release notes for JavaFX 18.0.1 to the repository


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/785/head:pull/785
$ git checkout pull/785

Update a local copy of the PR:
$ git checkout pull/785
$ git pull https://git.openjdk.java.net/jfx pull/785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 785

View PR using the GUI difftool:
$ git pr show -t 785

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/785.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back abhinayagarwal! A progress list of the required criteria for merging this PR into jfx18 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@johanvos johanvos requested a review from kevinrushforth Apr 26, 2022
@kevinrushforth
Copy link
Member

kevinrushforth commented Apr 26, 2022

The following two non-public (security) fixes are also included in 18.0.1:

JDK-8276371 (not public) | Better long buffering | web
JDK-8277465 (not public) | Additional fix for JDK-8276371 | web

@abhinayagarwal abhinayagarwal marked this pull request as ready for review Apr 26, 2022
@openjdk openjdk bot added the rfr label Apr 26, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@abhinayagarwal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285475: Create release notes for 18.0.1

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx18 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 26, 2022
@abhinayagarwal
Copy link
Contributor Author

abhinayagarwal commented Apr 26, 2022

/integrate

@openjdk openjdk bot added the sponsor label Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@abhinayagarwal
Your change (at version b3e05cc) is now ready to be sponsored by a Committer.

@nlisker
Copy link
Collaborator

nlisker commented Apr 26, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

Going to push as commit f0099c2.

@openjdk openjdk bot added the integrated label Apr 26, 2022
@openjdk openjdk bot closed this Apr 26, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@nlisker @abhinayagarwal Pushed as commit f0099c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants