Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants #791

Closed

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented May 6, 2022

This PR extends the check if a treeItem is expanded to all its ancestors, as in case one ancestor is collapsed, all its children will be hidden.

4 tests are included, two for TreeView and two for TreeTableView.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/791/head:pull/791
$ git checkout pull/791

Update a local copy of the PR:
$ git checkout pull/791
$ git pull https://git.openjdk.java.net/jfx pull/791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 791

View PR using the GUI difftool:
$ git pr show -t 791

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/791.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@openjdk
Copy link

openjdk bot commented May 20, 2022

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
  • 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
  • 7bb4819: 8283869: Update attribution in webkit.md file
  • e24eece: 8285534: Update the 3D lighting test sample
  • ee7f23d: 8283318: Videos with unusual sizes cannot be played on windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 20, 2022
@jperedadnr
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2022

Going to push as commit 19a855e.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
  • 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
  • 7bb4819: 8283869: Update attribution in webkit.md file
  • e24eece: 8285534: Update the 3D lighting test sample
  • ee7f23d: 8283318: Videos with unusual sizes cannot be played on windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2022
@openjdk openjdk bot closed this May 22, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 22, 2022
@openjdk
Copy link

openjdk bot commented May 22, 2022

@jperedadnr Pushed as commit 19a855e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants