-
Notifications
You must be signed in to change notification settings - Fork 541
8285253: Update boot JDK to 18.0.1 #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
|
@arapte is there a reason this is in Draft? I think we can review and integrate is, no? |
Yes Johan, There were few system tests failing with updated boot jdk. It turns out they fail with earlier boot jdk too(with 17 too). Reported the issue here : JDK-8288652, which does not seem like a blocker. |
|
/reviewers 2 |
|
@kevinrushforth |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me. The failing tests you are seeing pass for me. They might be caused by a color profile problem on your system. See the comment I added to JDK-8288652.
|
I noticed that the title of this PR doesn't exactly match the title of the JBS bug -- this PR title is all lower case. I suspect that Skara will flag this, although it would be an interesting test to leave it alone until both approvals are done to see if it will. Please change it before integrating it. |
johanvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all green for me.
|
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Yes, the tests pass when changed color profile. |
|
/integrate |
|
Going to push as commit 1f62570.
Your commit was automatically rebased without conflicts. |
Update Boot JDK to 18.0.1
Creating PR to initiate GitHub actions build.
Tested locally on Mac OS Catalina.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/792/head:pull/792$ git checkout pull/792Update a local copy of the PR:
$ git checkout pull/792$ git pull https://git.openjdk.org/jfx pull/792/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 792View PR using the GUI difftool:
$ git pr show -t 792Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/792.diff