Skip to content

Conversation

@arapte
Copy link
Member

@arapte arapte commented May 10, 2022

Update Boot JDK to 18.0.1
Creating PR to initiate GitHub actions build.
Tested locally on Mac OS Catalina.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/792/head:pull/792
$ git checkout pull/792

Update a local copy of the PR:
$ git checkout pull/792
$ git pull https://git.openjdk.org/jfx pull/792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 792

View PR using the GUI difftool:
$ git pr show -t 792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/792.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@johanvos
Copy link
Collaborator

@arapte is there a reason this is in Draft? I think we can review and integrate is, no?

@arapte
Copy link
Member Author

arapte commented Jun 17, 2022

@arapte is there a reason this is in Draft? I think we can review and integrate is, no?

Yes Johan, There were few system tests failing with updated boot jdk. It turns out they fail with earlier boot jdk too(with 17 too). Reported the issue here : JDK-8288652, which does not seem like a blocker.

@arapte arapte marked this pull request as ready for review June 17, 2022 08:10
@openjdk openjdk bot added the rfr Ready for review label Jun 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2022

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 25, 2022

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. The failing tests you are seeing pass for me. They might be caused by a color profile problem on your system. See the comment I added to JDK-8288652.

@kevinrushforth
Copy link
Member

I noticed that the title of this PR doesn't exactly match the title of the JBS bug -- this PR title is all lower case. I suspect that Skara will flag this, although it would be an interesting test to leave it alone until both approvals are done to see if it will. Please change it before integrating it.

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green for me.

@openjdk
Copy link

openjdk bot commented Jun 25, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285253: Update boot JDK to 18.0.1

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • da5bd37: 8277756: DatePicker listener might not be added when using second constructor
  • 864792d: 8284654: Modal behavior returns to wrong stage
  • 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
  • f534850: 8088420: JavaFX WebView memory leak via EventListener
  • d677003: 8286256: Update libxml2 to 2.9.14
  • 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
  • 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
  • 7bb4819: 8283869: Update attribution in webkit.md file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jun 25, 2022
@arapte arapte changed the title 8285253: update boot jdk to 18.0.1 8285253: Update boot JDK to 18.0.1 Jun 27, 2022
@arapte
Copy link
Member Author

arapte commented Jun 27, 2022

Look good to me. The failing tests you are seeing pass for me. They might be caused by a color profile problem on your system. See the comment I added to JDK-8288652.

Yes, the tests pass when changed color profile.

@arapte
Copy link
Member Author

arapte commented Jun 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit 1f62570.
Since your change was applied there have been 11 commits pushed to the master branch:

  • c759286: 8286774: Replace openjdk.java.net with openjdk.org
  • da5bd37: 8277756: DatePicker listener might not be added when using second constructor
  • 864792d: 8284654: Modal behavior returns to wrong stage
  • 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
  • f534850: 8088420: JavaFX WebView memory leak via EventListener
  • d677003: 8286256: Update libxml2 to 2.9.14
  • 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
  • 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
  • ... and 1 more: https://git.openjdk.org/jfx/compare/e24eeceb28741f4a044ea2cb0cb23a1174b27c66...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@arapte Pushed as commit 1f62570.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the boot-jdk-update branch July 12, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants