Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8286256 : Update libxml2 to 2.9.14 #797

Closed
wants to merge 13 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented May 17, 2022

Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for windows , linux and Mac platforms and updated the files accordingly.

Updated libxslt to version 1.1.35. Generated the config.h files for windows , Mac and linux platforms and updated accordingly.

Verified the build on all the platforms and sanity testing looks fine.No regressions observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 reviewer, 1 author)

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/797/head:pull/797
$ git checkout pull/797

Update a local copy of the PR:
$ git checkout pull/797
$ git pull https://git.openjdk.java.net/jfx pull/797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 797

View PR using the GUI difftool:
$ git pr show -t 797

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/797.diff

@HimaBinduMeda
Copy link
Contributor Author

HimaBinduMeda commented May 17, 2022

/issue add 8286257

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2022

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda
Copy link
Contributor Author

HimaBinduMeda commented May 17, 2022

Creating UPDATING.txt for libxslt. Will commit it once done.

@openjdk
Copy link

openjdk bot commented May 17, 2022

@HimaBinduMeda Unknown command add - for a list of valid commands use /help.

@openjdk openjdk bot added the rfr label May 17, 2022
@HimaBinduMeda
Copy link
Contributor Author

HimaBinduMeda commented May 17, 2022

/issue add 8286257

@openjdk
Copy link

openjdk bot commented May 17, 2022

@HimaBinduMeda
Adding additional issue to issue list: 8286257: Update libxslt to 1.1.35.

@mlbridge
Copy link

mlbridge bot commented May 17, 2022

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented May 17, 2022

/reviewers 2

@openjdk
Copy link

openjdk bot commented May 17, 2022

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with 1 of role reviewers, 1 of role authors).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

The code changes look good. I tested it on 3 platforms. All good.

I left a few inline comments, including a couple questions about whitespace diffs. I notice that there are 27 files that only have whitespace changes and no other diffs, as well as one more where the whitespace diffs are the majority of the changes. Is this intentional?

Copy link
Member

@kevinrushforth kevinrushforth left a comment

The updated instructions look good with one minor issue (a missing space between a . and the start of the next sentence).

@kevinrushforth
Copy link
Member

kevinrushforth commented May 18, 2022

@johanvos or @tiainen Can one of you be the second reviewer on this?

Copy link
Collaborator

@johanvos johanvos left a comment

works with our new build approach.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286256: Update libxml2 to 2.9.14
8286257: Update libxslt to 1.1.35

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 23, 2022
@HimaBinduMeda
Copy link
Contributor Author

HimaBinduMeda commented May 23, 2022

/integrate

@openjdk openjdk bot added the sponsor label May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@HimaBinduMeda
Your change (at version e3ea663) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

kevinrushforth commented May 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit d677003.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
  • 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
  • 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready rfr sponsor labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@kevinrushforth @HimaBinduMeda Pushed as commit d677003.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants