8231870: CrossLibs script for armv6hf toolchain download fails #8
Conversation
Hi dellgreen, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dellgreen" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/signed |
https://www.oracle.com/technetwork/community/oca-486395.html#i Ideaworks Ltd. - OpenJDK OpenJFX - dellgreen |
i don't know why jcheck is failing this, when a different pull-request i submitted yesterday works fine. They both look like they adhere to the guidelines? |
…mes for wheezy Updated crosslibs-armv6hf.sh with new toolchain location domain names as wheezy is end of life
f809aab
to
bb4bcc9
For some reason the RFR email wasn't sent. The Skara team is looking into this and should have a solution soon. In the mean time, we can proceed with the review. |
@johanvos can you review this? |
I don't have any particular issue with this change, but I will defer the review to @johanvos. It does highlight an existing problem where we are still using an |
@@ -228,7 +228,7 @@ installLibs() { | |||
|
|||
getPackages \ | |||
$DESTINATION \ | |||
http://ftp.us.debian.org/debian/ wheezy main armhf \ | |||
http://archive.debian.org/debian/ wheezy main armhf \ |
kevinrushforth
Oct 7, 2019
Member
The use of http://
URLs to download artifacts is strongly discouraged, since it isn't secure. Is there a valid https://
URL that can be used instead? I note that just substituting http
with https
in the above URL does not work.
The use of http://
URLs to download artifacts is strongly discouraged, since it isn't secure. Is there a valid https://
URL that can be used instead? I note that just substituting http
with https
in the above URL does not work.
octylFractal
Oct 7, 2019
In general a lot of Debian package URLs are not HTTPS by default because of apt's built-in signature checking, https://whydoesaptnotusehttps.com/. However, it does seem like it should at least be supported, so it might be a bug in the debian.org
server config.
Additionally, I see that the getPackages
command doesn't check these signatures. It probably should, but that's another PR.
In general a lot of Debian package URLs are not HTTPS by default because of apt's built-in signature checking, https://whydoesaptnotusehttps.com/. However, it does seem like it should at least be supported, so it might be a bug in the debian.org
server config.
Additionally, I see that the getPackages
command doesn't check these signatures. It probably should, but that's another PR.
@@ -389,7 +389,7 @@ installLibs() { | |||
# get some rapberry Pi specials | |||
getPackages \ | |||
$DESTINATION \ | |||
http://archive.raspbian.org/raspbian wheezy firmware armhf \ | |||
http://legacy.raspbian.org/raspbian wheezy firmware armhf \ |
kevinrushforth
Oct 7, 2019
Member
Same comment hear about using an https
URL if possible.
Same comment hear about using an https
URL if possible.
https for legacy.raspbian.org works |
I confirm that without the patch, the "cross-build tools" can not be fetched. With this patch, the tools can be fetched and the build can be created using these tools. However, in general I think the concept of this crosslibs script is broken for a number of reasons:
Rethinking the concept of cross-compiliation involves much more than just downloading a cross-compiler and libs, and we should not fix that in a rush. I therefore propose to merge this PR. |
You are already a known contributor! |
I am going to temporarily change the title in an attempt to force the jcheck bot to run again. I'll change it back once done. Failing this, I will ask the Skara admins to rerun the check if possible. If this doesn't work, we will need to close this PR and have you open a new one. |
Looks like that worked and reran jcheck. |
Please ignore the above comments. I added them to the wrong PR. This PR was and still is ready for review. |
I am ok with the PR as is. The decision on how to install build tools (e.g. via apt-get, via a zip download, over http, over https) is not part of the code repository, and can be specific to the distributor. |
@dellgreen This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.
|
I'll suspend testing of the https domains as previously mentioned. |
@dellgreen once you are ready, go ahead and issue the |
/integrate |
@dellgreen |
While checking, I notice that this PR has a different title than the title of the corresponding bug in JBS: https://bugs.openjdk.java.net/browse/JDK-8231870. |
Btw, my username is @kevinrushforth so you notified someone else on the above comment... Yes, editing the title to match the JBS issue is a very good thing to do. Since you are sponsoring it, go ahead and do that. I don't know for certain whether the bot will pick it up (since the contributor has already done a |
I don't see a way to edit the commit message, so I'll just sponsor it and see if the bot modifies the commit message with the new title or not. |
/sponsor |
@johanvos @dellgreen The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 63fe66c. |
I see that the bot did update the commit message to match your change to the title. Nice. |
buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be able to cross compile javafx for arm hard float. Up to now the upstream distribution versions have been debian and raspbian wheezy, but these are now end of life and have been archived to servers that have different domain names.
Tried to change to use jessie but this generates a whole load of __THROWNL errors, so for now have updated the domain names to point to new servers so that wheezy packages can still be retrieved and cross compilation succeeds.
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8231870
Progress
Issue
JDK-8231870: CrossLibs script for armv6hf toolchain download fails
Approvers