Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233798: Ctrl-L character mistakenly removed from gstreamer.md #80

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 7, 2020

Fix for JDK-8233798

Simple fix to restore a Ctrl-L character that was mistakenly deleted as part of the cleanup fix done for JDK-8222746. After the missing ^L is restored the license is once again identical between gstreamer.md and glib.md (and webkit.md) as it should be.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8233798: Ctrl-L character mistakenly removed from gstreamer.md

Approvers

  • Alexander Matveev (almatvee - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Jan 7, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 7, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 7, 2020

@sashamatveev can you review this?

@mlbridge
Copy link

mlbridge bot commented Jan 7, 2020

Webrevs

Copy link

sashamatveev left a comment

Looks good.

@openjdk openjdk bot removed the rfr label Jan 7, 2020
@openjdk
Copy link

openjdk bot commented Jan 7, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8233798: Ctrl-L character mistakenly removed from gstreamer.md

Reviewed-by: almatvee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.
    ➡️ To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jan 7, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 7, 2020

/integrate

@openjdk openjdk bot closed this Jan 7, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 7, 2020
@openjdk
Copy link

openjdk bot commented Jan 7, 2020

@kevinrushforth
Pushed as commit df8b3c5.

@mlbridge
Copy link

mlbridge bot commented Jan 7, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: df8b3c5
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-07 21:19:25 +0000
URL: https://git.openjdk.java.net/jfx/commit/df8b3c50

8233798: Ctrl-L character mistakenly removed from gstreamer.md

Reviewed-by: almatvee

! modules/javafx.media/src/main/legal/gstreamer.md

@kevinrushforth kevinrushforth deleted the kevinrushforth:8233798-gstreamer-license branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.