8277756: DatePicker listener might not be added when using second constructor

[Maran23]

The valueProperty() and chronologyProperty() listener are now added in the second constructor of DatePicker
(public DatePicker(LocalDate localDate)) instead of the first one (public DatePicker()).
Therefore, both listener are now added no matter which constructor is used.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8277756: DatePicker listener might not be added when using second constructor

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/801/head:pull/801
$ git checkout pull/801

Update a local copy of the PR:
$ git checkout pull/801
$ git pull https://git.openjdk.java.net/jfx pull/801/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 801

View PR using the GUI difftool:
$ git pr show -t 801

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/801.diff

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (74ad0cc8)

[aghaisas]

Looks good to me.

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277756: DatePicker listener might not be added when using second constructor

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 864792d: 8284654: Modal behavior returns to wrong stage
• 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
• f534850: 8088420: JavaFX WebView memory leak via EventListener
• d677003: 8286256: Update libxml2 to 2.9.14
• 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
• 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
• 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
• 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
• 7bb4819: 8283869: Update attribution in webkit.md file
• e24eece: 8285534: Update the 3D lighting test sample
• ... and 33 more: https://git.openjdk.java.net/jfx/compare/eb7fa5dd1c0911bca15576060691d884d29895a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Maran23]

/integrate

[openjdk]

@Maran23
Your change (at version 74ad0cc) is now ready to be sponsored by a Committer.

[aghaisas]

/sponsor

[openjdk]

Going to push as commit da5bd37.
Since your change was applied there have been 43 commits pushed to the master branch:

• 864792d: 8284654: Modal behavior returns to wrong stage
• 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
• f534850: 8088420: JavaFX WebView memory leak via EventListener
• d677003: 8286256: Update libxml2 to 2.9.14
• 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
• 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
• 81e1cc3: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set
• 6c6545f: 8285217: [Android] Window's screen is not updated after native screen was disposed
• 7bb4819: 8283869: Update attribution in webkit.md file
• e24eece: 8285534: Update the 3D lighting test sample
• ... and 33 more: https://git.openjdk.java.net/jfx/compare/eb7fa5dd1c0911bca15576060691d884d29895a1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aghaisas @Maran23 Pushed as commit da5bd37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.