8289751: Multiple unit test failures after JDK-8251483

[Maran23]

As also discussed in the ticket, we need to disable/ignore this two tests for now.

With the fix for JDK-8251483 the table row item is never null in a non empty table cell.
In the meantime with JDK-8251480 and JDK-8285197 we changed the table column header autosizing to be more complete by adding the table row to the setup.
Unfortunately we don't set the table view for the table row, therefore it can not know the underlying item (he knows the index but not where he can get the corresponding data for that index) -> table row item can be null in a non empty table cell (again).

This will be fixed in #805 (and the tests can be reenabled)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289751: Multiple unit test failures after JDK-8251483

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/811/head:pull/811
$ git checkout pull/811

Update a local copy of the PR:
$ git checkout pull/811
$ git pull https://git.openjdk.org/jfx pull/811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 811

View PR using the GUI difftool:
$ git pr show -t 811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/811.diff

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (952dbb4f)

[kevinrushforth]

Looks good. I confirm that all tests pass after this. As discussed in the JBS issue, we might want to file a follow-on issue to investigate the cascading failures caused when these two tests fail.

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289751: Multiple unit test failures after JDK-8251483

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kevinrushforth]

Thank you for fixing this quickly.

[Maran23]

/integrate

[openjdk]

@Maran23
Your change (at version 952dbb4) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit b9f3907.

[openjdk]

@kevinrushforth @Maran23 Pushed as commit b9f3907.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[Maran23]

Thank you for fixing this quickly.

Thank you very much for your time as well! I am glad that I could help.