Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289395: Fix warnings: Varargs methods should only override or be overridden by other varargs methods #816

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Jul 6, 2022

  • fixed varargs

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289395: Fix warnings: Varargs methods should only override or be overridden by other varargs methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/816/head:pull/816
$ git checkout pull/816

Update a local copy of the PR:
$ git checkout pull/816
$ git pull https://git.openjdk.org/jfx pull/816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 816

View PR using the GUI difftool:
$ git pr show -t 816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/816.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2022

👋 Welcome back andy-goryachev-oracle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2022

Webrevs

@kevinrushforth kevinrushforth requested a review from arapte July 7, 2022 21:48
@openjdk
Copy link

openjdk bot commented Jul 10, 2022

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289395: Fix warnings: Varargs methods should only override or be overridden by other varargs methods

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • c7d3fd9: 8283402: Update to gcc 11.2 on Linux
  • cbb53b2: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
  • 187fbe1: 8289381: Fix warnings: The assignment to variable has no effect
  • 60c75b8: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue
  • 178d898: 8276056: Control.skin.setSkin(Skin) fails to call dispose() on discarded Skin
  • fc6a602: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255
  • 4dcd9e0: 8289171: Blank final field 'dialog' may not have been initialized in scene.control.Dialog:521
  • 28b8220: 8279297: Remove Shape::setMode method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jul 10, 2022
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@andy-goryachev-oracle
Your change (at version 3a18af5) is now ready to be sponsored by a Committer.

@nlisker
Copy link
Collaborator

nlisker commented Jul 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit 13f3e1f.
Since your change was applied there have been 8 commits pushed to the master branch:

  • c7d3fd9: 8283402: Update to gcc 11.2 on Linux
  • cbb53b2: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
  • 187fbe1: 8289381: Fix warnings: The assignment to variable has no effect
  • 60c75b8: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue
  • 178d898: 8276056: Control.skin.setSkin(Skin) fails to call dispose() on discarded Skin
  • fc6a602: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255
  • 4dcd9e0: 8289171: Blank final field 'dialog' may not have been initialized in scene.control.Dialog:521
  • 28b8220: 8279297: Remove Shape::setMode method

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@nlisker @andy-goryachev-oracle Pushed as commit 13f3e1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8289395.varargs branch July 11, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants