8284676: TreeTableView loses sort ordering when applied on empty table

[arapte]

Issue: In a TreeTableView if root item has no children then TreeTableView does not retain if a sort order is set.

Cause: This is a regression of fix for JDK-8256283, which returned false from SortPolicy.call() function if root item has no children. This function is called from TreeTableView.sort() line #1863. When the returned value is false then line #1885 gets executed, which removes the sort order that was added.

Fix: The fix for JDK-8256283 is modified to return true instead. Added a test that fails without and passes with fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8284676: TreeTableView loses sort ordering when applied on empty table

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Jose Pereda (@jperedadnr - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/825/head:pull/825
$ git checkout pull/825

Update a local copy of the PR:
$ git checkout pull/825
$ git pull https://git.openjdk.org/jfx pull/825/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 825

View PR using the GUI difftool:
$ git pr show -t 825

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/825.diff

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (39353ce3)
• 00: Full (5768d03c)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

@aghaisas or @jperedadnr can one of you be the second reviewer?

[kevinrushforth]

Looks good. I confirm that the newly added test passes with the fix and fails without.

[jperedadnr]

Looks good, minor naming issue

[openjdk]

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284676: TreeTableView loses sort ordering when applied on empty table

Reviewed-by: kcr, jpereda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[arapte]

/integrate

[openjdk]

Going to push as commit 0132ac8.

[openjdk]

@arapte Pushed as commit 0132ac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.