8290037: Bindings should clean up after themselves when their weak listeners go out of scope

[hjohn]

This is an initial (incomplete) implementation of 8290037 for evaluation.

If the approach is agreed, I will modify the rest of the *PropertyBase classes which use weak listeners, and add some tests.

I didn't use Cleaner because cleaning up a listener may block.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request matching fixVersion openjfx19 to be approved (needs to be created)
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with the updated jcheck configuration)

Issue

• JDK-8290037: Bindings should clean up after themselves when their weak listeners go out of scope

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/827/head:pull/827
$ git checkout pull/827

Update a local copy of the PR:
$ git checkout pull/827
$ git pull https://git.openjdk.org/jfx.git pull/827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 827

View PR using the GUI difftool:
$ git pr show -t 827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/827.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (e2e516a6)
• 00: Full (c2a15137)

[kevinrushforth]

If we go this route it warrants updates to the API docs to describe the behavioral changes being introduced. Specifically, the synchronizing of the add / remove listener methods and any changes to the lifecycle of the bindings.

/reviewers 2
/csr

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[openjdk]

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@hjohn please create a CSR request for issue JDK-8290037 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[hjohn]

If we go this route it warrants updates to the API docs to describe the behavioral changes being introduced. Specifically, the synchronizing of the add / remove listener methods and any changes to the lifecycle of the bindings.

/reviewers 2 /csr

Ah, I was hoping this was one of the routes without requiring a csr. Perhaps it needs a rethink.

[openjdk]

@hjohn this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout feature/cleaner-for-listeners
git fetch https://git.openjdk.org/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@hjohn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@hjohn This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.