Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236733: Change JavaFX release version to 15 #83

Closed
wants to merge 1 commit into from

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 9, 2020

JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733).

Bump the release version to 15. As noted in the JBS issue, I will wait until right after the jfx14 fork to integrate this.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8236733: Change JavaFX release version to 15

Approvers

  • Ambarish Rapte (arapte - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Jan 9, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 9, 2020

Reviewer: @arapte

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 9, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2020

Webrevs

@arapte
arapte approved these changes Jan 9, 2020
Copy link

arapte left a comment

Looks good to me.

@openjdk openjdk bot removed the rfr label Jan 9, 2020
@openjdk
Copy link

openjdk bot commented Jan 9, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8236733: Change JavaFX release version to 15

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 9, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 10, 2020

/integrate

@openjdk openjdk bot closed this Jan 10, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 10, 2020
@openjdk
Copy link

openjdk bot commented Jan 10, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • f907026: 8236808: javafx_iio can not be used in static environment
  • e6587ff: 8236448: Remove unused and repair broken Android/Dalvik code
  • c9519b6: 8232589: Remove CoreAudio Utility Classes
  • df8b3c5: 8233798: Ctrl-L character mistakenly removed from gstreamer.md

Your commit was automatically rebased without conflicts.

Pushed as commit a557dd9.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: a557dd9
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-10 13:19:21 +0000
URL: https://git.openjdk.java.net/jfx/commit/a557dd95

8236733: Change JavaFX release version to 15

Reviewed-by: arapte

! build.properties
! modules/javafx.base/src/test/java/test/com/sun/javafx/runtime/VersionInfoTest.java

@kevinrushforth kevinrushforth deleted the kevinrushforth:8236733-jfx-15 branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.