Skip to content

8279514: NPE on clearing value of IntegerSpinnerValueFactory #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8279514: NPE on clearing value of IntegerSpinnerValueFactory #865

wants to merge 2 commits into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Aug 10, 2022 •
edited by openjdk bot
Loading

A null check has been added to below SpinnerValueFactory classes in valueProperty() ChangeListeners-

  • IntegerSpinnerValueFactory
  • LocalDateSpinnerValueFactory
  • LocalTimeSpinnerValueFactory
  • ListSpinnerValueFactory

Added 5 tests that detect NPE for above 4 Spinner factories.
Only DoubleSpinnerValueFactory already had a valid null check - so the test for it passes before and after.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279514: NPE on clearing value of IntegerSpinnerValueFactory

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/865/head:pull/865
$ git checkout pull/865

Update a local copy of the PR:
$ git checkout pull/865
$ git pull https://git.openjdk.org/jfx pull/865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 865

View PR using the GUI difftool:
$ git pr show -t 865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/865.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2022

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 10, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2022 •
edited
Loading

Webrevs

Maran23
Maran23 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@Maran23 Maran23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good and follows the same pattern as in DoubleSpinnerValueFactory.
Left one minor suggestion for all added tests.

Maran23
Maran23 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@Maran23 Maran23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinrushforth kevinrushforth self-requested a review August 27, 2022 14:30
kevinrushforth
kevinrushforth approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279514: NPE on clearing value of IntegerSpinnerValueFactory

Reviewed-by: mhanl, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 1, 2022
@aghaisas
Copy link
Collaborator Author

aghaisas commented Sep 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

Going to push as commit d1a7ebd.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2022
@openjdk openjdk bot closed this Sep 2, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@aghaisas Pushed as commit d1a7ebd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

+1 more reviewer

@Maran23 Maran23 Maran23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aghaisas @kevinrushforth @Maran23