8292391: Add support for optional signing of native libraries

[kevinrushforth]

This PR enables an optional signing step inserted into the build right after the step to strip binaries that was added by JDK-8278260. As is the case with the strip step, the optional signing is only ever enabled for production builds when running with gradle -PCONF=Release.

This is an optional step, meaning that codeSignCmd and codeSignArgs need to be provided by scripts external to the repo in order to enable it. By default, they are not defined, so the additional logic added by this PR will do nothing.

NOTE: as with the fix for JDK-8278260, this PR adds three copies of the build logic. I filed JDK-8292506 to refactor both of them (strip and sign), and to look for other duplication as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292391: Add support for optional signing of native libraries

Reviewers

• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/871/head:pull/871
$ git checkout pull/871

Update a local copy of the PR:
$ git checkout pull/871
$ git pull https://git.openjdk.org/jfx pull/871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 871

View PR using the GUI difftool:
$ git pr show -t 871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/871.diff

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (7a765277)

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292391: Add support for optional signing of native libraries

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• b951503: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
• bee2dfb: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane
• d4ff45a: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
• 8815981: 8271395: Crash during printing when disposing textures
• cedc17c: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant
• 5c47295: 8290473: update Eclipse .classpath in apps, buildSrc
• 2618bf8: 8181084: JavaFX show big icons in system menu on macOS with Retina display
• eaddb0f: 8291908: VirtualFlow creates unneeded empty cells

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit dee34b4.
Since your change was applied there have been 8 commits pushed to the master branch:

• b951503: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
• bee2dfb: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane
• d4ff45a: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
• 8815981: 8271395: Crash during printing when disposing textures
• cedc17c: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant
• 5c47295: 8290473: update Eclipse .classpath in apps, buildSrc
• 2618bf8: 8181084: JavaFX show big icons in system menu on macOS with Retina display
• eaddb0f: 8291908: VirtualFlow creates unneeded empty cells

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth Pushed as commit dee34b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.