8289542: Update JPEG Image Decoding Software to 9e

[arapte]

Update libjpeg to current version release 9e of 16-Jan-2022

reference: https://jpegclub.org/reference/reference-sources/

Verified all test run on Windows and MacOS

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8289542: Update JPEG Image Decoding Software to 9e

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/874/head:pull/874
$ git checkout pull/874

Update a local copy of the PR:
$ git checkout pull/874
$ git pull https://git.openjdk.org/jfx pull/874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 874

View PR using the GUI difftool:
$ git pr show -t 874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/874.diff

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (22a4295b)

[kevinrushforth]

Can you rerun the macOS GHA job? It timed out downloading ant. Btw, we've seen this a lot more lately, so I filed JDK-8292549 to track it.

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

Looks good. I tested on all three platforms. I left a couple comments on questionable-looking indentation.

[arapte]

I left a couple comments on questionable-looking indentation.

Hi Kevin, Looks like this is an existing issue, as we replace tabs with 4 spaces.
We have several such existing instances of incorrect layout.

1. jfx/modules/javafx.graphics/src/main/native-iio/libjpeg/jdmaster.c

   Line 142 in 5c47295

   ssize = ssize * 2;

2. jfx/modules/javafx.graphics/src/main/native-iio/libjpeg/jdmaster.c

   Line 439 in 5c47295

   cinfo->cquantize = master->quantizer_2pass;

3. jfx/modules/javafx.graphics/src/main/native-iio/libjpeg/jdhuff.c

   Line 438 in 5c47295

   ERREXIT(cinfo, JERR_BAD_HUFF_TABLE);

[kevinrushforth]

Looks like this is an existing issue, as we replace tabs with 4 spaces.
We have several such existing instances of incorrect layout.

Perhaps it would be better to replace TABS with 8 spaces for libjpeg since it looks like that is what their source base assumes? If we were to do that, it would need to be done separately and not part of this update, since we would want to do it consistently for all TABS and not just the ones on lines modified by this update. It may or may not be worth a follow-up cleanup issue.

[openjdk]

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289542: Update JPEG Image Decoding Software to 9e

Reviewed-by: kcr, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 6d6726c: Merge
• 8b96776: 8286678: Fix mistakes in FX API docs
• 5c00783: 8291906: Bindings.createXxxBinding inherit incorrect method docs
• 7cb8d67: 8235491: Tree/TableView: implementation of isSelected(int) violates contract
• dee34b4: 8292391: Add support for optional signing of native libraries
• b951503: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
• bee2dfb: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane
• d4ff45a: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
• 8815981: 8271395: Crash during printing when disposing textures
• cedc17c: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant
• ... and 3 more: https://git.openjdk.org/jfx/compare/33534cb9e0524e91ed717b22fab667b284c52252...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[arapte]

/integrate

[openjdk]

Going to push as commit f95f09f.
Since your change was applied there have been 13 commits pushed to the master branch:

• 6d6726c: Merge
• 8b96776: 8286678: Fix mistakes in FX API docs
• 5c00783: 8291906: Bindings.createXxxBinding inherit incorrect method docs
• 7cb8d67: 8235491: Tree/TableView: implementation of isSelected(int) violates contract
• dee34b4: 8292391: Add support for optional signing of native libraries
• b951503: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
• bee2dfb: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane
• d4ff45a: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
• 8815981: 8271395: Crash during printing when disposing textures
• cedc17c: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant
• ... and 3 more: https://git.openjdk.org/jfx/compare/33534cb9e0524e91ed717b22fab667b284c52252...master

Your commit was automatically rebased without conflicts.

[openjdk]

@arapte Pushed as commit f95f09f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.