8291906: Bindings.createXxxBinding inherit incorrect method docs

[nlisker]

Added docs for inherited methods in Bindings subclasses.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291906: Bindings.createXxxBinding inherit incorrect method docs

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/881/head:pull/881
$ git checkout pull/881

Update a local copy of the PR:
$ git checkout pull/881
$ git pull https://git.openjdk.org/jfx pull/881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 881

View PR using the GUI difftool:
$ git pr show -t 881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/881.diff

[bridgekeeper]

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into jfx19 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (d3ddf424)

[kevinrushforth]

As far as I can tell, none of these are public API and so don't show up in the docs. (If they were, then the lack of an @return in a few places would generate a warning which we are not seeing. Are you building the docs with a setting that produces docs for non-public classes?

If that's the reason for doing this, then it probably doesn't need to go into 19 (although, since we are going to generate the docs again anyway., I won't object).

[nlisker]

I don't mind either way. I initially bundled it with the issue for fixing API docs, but decoupled it later and just thought it would be fine to do them both. The changes are very straightforward.

Are you building the docs with a setting that produces docs for non-public classes?

No, but Eclipse shows internal docs also. I suspect other IDEs do so as well.

[kevinrushforth]

Looks fine. I left a question about the missing @return tags, but it might not matter here depending on whether the IDEs care.

[openjdk]

@nlisker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291906: Bindings.createXxxBinding inherit incorrect method docs

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx19 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx19 branch, type /integrate in a new comment.

[nlisker]

/integrate

[openjdk]

Going to push as commit 5c00783.

[openjdk]

@nlisker Pushed as commit 5c00783.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.