Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292609 : Cherry-pick WebKit 614.1 stabilization fixes #885

Closed

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Aug 26, 2022

Stabilization fixes from WebKitGTK 2.36.7.
Verified drt and unit tests on Mac, Windows and Linux platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8292609: Cherry-pick WebKit 614.1 stabilization fixes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/885/head:pull/885
$ git checkout pull/885

Update a local copy of the PR:
$ git checkout pull/885
$ git pull https://git.openjdk.org/jfx pull/885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 885

View PR using the GUI difftool:
$ git pr show -t 885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/885.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

@kevinrushforth kevinrushforth self-requested a review August 26, 2022 12:03
@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

@johanvos or @tiainen do one of you also want to review? I don't think there are any changes that would affect your being able to build it, but since there are a few changes, you might want to to a test build.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my testing looks good. The code changes look good.

@kevinrushforth kevinrushforth requested a review from arapte August 26, 2022 22:24
Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a build, ATR, sanity check on MacOS. LGTM

@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292609: Cherry-pick WebKit 614.1 stabilization fixes

Reviewed-by: kcr, arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 996eb84: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Aug 29, 2022
@johanvos
Copy link
Collaborator

I'll do a test build.

@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Aug 29, 2022
@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@HimaBinduMeda
Your change (at version 2f3a88d) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 29, 2022

Going to push as commit da580ba.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 996eb84: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2022
@openjdk openjdk bot closed this Aug 29, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Aug 29, 2022
@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@kevinrushforth @HimaBinduMeda Pushed as commit da580ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants