-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292609 : Cherry-pick WebKit 614.1 stabilization fixes #885
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my testing looks good. The code changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a build, ATR, sanity check on MacOS. LGTM
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte, @johanvos) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I'll do a test build. |
/integrate |
@HimaBinduMeda |
/sponsor |
@kevinrushforth @HimaBinduMeda Pushed as commit da580ba. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Stabilization fixes from WebKitGTK 2.36.7.
Verified drt and unit tests on Mac, Windows and Linux platforms.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/885/head:pull/885
$ git checkout pull/885
Update a local copy of the PR:
$ git checkout pull/885
$ git pull https://git.openjdk.org/jfx pull/885/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 885
View PR using the GUI difftool:
$ git pr show -t 885
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/885.diff