Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8226754: FX build fails using gradle 5.6+ or 6 #9
JBS issue: JDK-8226754
As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not building correctly with 5.6 or later).
The existing JavaFX build uses two deprecated features that are removed in gradle 6, so the build fails when building with gradle 6. Additionally, some change that went into gradle 5.6 prevents all of our resource files (e.g., css files, images, shaders) from being included in the built artifacts, which causes JavaFX to be non-functional (our unit tests catch this failure).
The purpose of this bug fix is to allow JavaFX to build with gradle 6, which is needed to allow building with JDK 13. We will likely upgrade to gradle 6 in the near future. Additionally, this fixes the resource bug that was exposed (or introduced) in gradle 5.6 and also affects gradle 6.
NOTE: the replacement for one of the deprecated APIs, ivy
The changes are as follows:
I verified that the build artifacts produced by gradle 5.3 before and after this changes are identical (so it is behavior neutral for the supported version of gradle). After the fix, I also verified that the build artifacts produced by gradle 5.6.2
JDK-8226754: FX build fails using gradle 5.6+ or 6
1. Remove unneeded STABLE_PUBLISHING setting 2. Bump minimum gradle version to 5.3 3. Use ivy patternLayout(...) instead of layout("pattern", ...) 4. Specify no metadata for ivy repositories 5. Set output.resourcesDir of sourceSet to match processResources.destinationDir
@kevinrushforth This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge