Skip to content

8237078: [macOS] Media build broken on XCode 11 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8237078: [macOS] Media build broken on XCode 11 #90

wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Jan 20, 2020 •
edited by openjdk bot
Loading

Fix JDK-8237078
replace the objc_msgSend call with a direct objC call.
The fix works on XCode 10.1 and XCode 11.3

Tested using
java -Djfxmedia.platforms=OSXPlatform
with MediaPlayer playing an mp3.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237078: [macOS] Media build broken on XCode 11

Approvers

  • Kevin Rushforth (kcr - Reviewer)
  • Alexander Matveev (almatvee - Reviewer)

@johanvos
Fix 8237078 : media build code broken on XCode 11
33582c1 
replace the objc_msgSend call with a direct objC call.

The fix works on XCode 10.1 and XCode 11.3
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Jan 20, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2020

Webrevs

kevinrushforth
kevinrushforth approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the fix, and confirmed that the new code is executed. This seems safe enough that a single reviewer is sufficient, although @sashamatveev might want to review as well.

@openjdk openjdk bot removed the rfr Ready for review label Jan 21, 2020
@openjdk
Copy link

openjdk bot commented Jan 21, 2020 •
edited
Loading

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237078: [macOS] Media build broken on XCode 11

Reviewed-by: kcr, almatvee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 21, 2020
sashamatveev
sashamatveev approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 21, 2020

@johanvos can you change the PR title to match the JBS title?

8237078: [macOS] Media build broken on XCode 11

@johanvos johanvos changed the title 8237078: Media build code broken on XCode 11 8237078: [macOS] Media build broken on XCode 11 Jan 22, 2020
@openjdk openjdk bot removed the ready Ready to be integrated label Jan 22, 2020
@johanvos johanvos changed the title 8237078: [macOS] Media build broken on XCode 11 8237078: [macOS] Media build broken on XCode 11 Jan 22, 2020
@openjdk openjdk bot added the ready Ready to be integrated label Jan 22, 2020
@johanvos
Copy link
Collaborator Author

johanvos commented Jan 22, 2020

/integrate

@openjdk openjdk bot closed this Jan 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Jan 22, 2020
@openjdk
Copy link

openjdk bot commented Jan 22, 2020

@johanvos
Pushed as commit be22e85.

@mlbridge
Copy link

mlbridge bot commented Jan 22, 2020

Mailing list message from Johan Vos on openjfx-dev:

Changeset: be22e85
Author: Johan Vos <jvos at openjdk.org>
Date: 2020-01-22 12:26:17 +0000
URL: https://git.openjdk.java.net/jfx/commit/be22e853

8237078: [macOS] Media build broken on XCode 11

Reviewed-by: kcr, almatvee

! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

+1 more reviewer

@sashamatveev sashamatveev sashamatveev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@johanvos johanvos

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johanvos @kevinrushforth @sashamatveev