8245145: Spinner: throws IllegalArgumentException when replacing skin

[andy-goryachev-oracle]

Fixed SpinnerSkin initialization using new Skin.install(). Also in this PR - fixing memory leaks in SpinnerSkin by properly removing all listeners and event filters added in the constructor, as well as any child Nodes.

NOTE: the fix requires both ListenerHelper JDK-8294809 and Skin.install() JDK-8290844 changes.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8245145: Spinner: throws IllegalArgumentException when replacing skin

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/904/head:pull/904
$ git checkout pull/904

Update a local copy of the PR:
$ git checkout pull/904
$ git pull https://git.openjdk.org/jfx pull/904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 904

View PR using the GUI difftool:
$ git pr show -t 904

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/904.diff

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[mlbridge]

Webrevs

• 04: Full - Incremental (5c4880af)
• 03: Full (f83fc9d6)
• 02: Full (c933b7b5)
• 01: Full (ac984b3d)
• 00: Full (bcb9c5f2)

[andy-goryachev-oracle]

@aghaisas @hjohn : could you please review?

[andy-goryachev-oracle]

@nlisker or @kevinrushforth could you take a look please?

[kevinrushforth]

Looks good with one minor formatting issue.

[kevinrushforth]

Minor: add a space after the if.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245145: Spinner: throws IllegalArgumentException when replacing skin

Reviewed-by: aghaisas, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f96b350: 8296854: NULL check of CTFontCopyAvailableTables return value is required

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit 07e693b.
Since your change was applied there have been 2 commits pushed to the master branch:

• 5b0d3b5: 8296621: Stage steals focus on scene change
• f96b350: 8296854: NULL check of CTFontCopyAvailableTables return value is required

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit 07e693b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.