8294589: MenuBarSkin: memory leak when changing skin

[andy-goryachev-oracle]

Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().

This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
See #908

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8294589: MenuBarSkin: memory leak when changing skin

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)
• John Hendrikx (@hjohn - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/906/head:pull/906
$ git checkout pull/906

Update a local copy of the PR:
$ git checkout pull/906
$ git pull https://git.openjdk.org/jfx pull/906/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 906

View PR using the GUI difftool:
$ git pr show -t 906

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/906.diff

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 21: Full (d4e6141f)
• 20: Full - Incremental (b546a15b)
• 19: Full (4434e5f7)
• 18: Full - Incremental (693667a5)
• 17: Full - Incremental (cbcc17e7)
• 16: Full (b51db815)
• 15: Full - Incremental (bdb8d828)
• 14: Full - Incremental (2a9d2095)
• 13: Full (45f3e374)
• 12: Full - Incremental (e1b7ea65)
• 11: Full - Incremental (405b14b7)
• 10: Full (f2ec9169)
• 09: Full - Incremental (bc3869ac)
• 08: Full - Incremental (1adc2a93)
• 07: Full - Incremental (92418aaf)
• 06: Full - Incremental (2ea27fc9)
• 05: Full - Incremental (21fc352e)
• 04: Full - Incremental (43841d5e)
• 03: Full - Incremental (f1b2d931)
• 02: Full - Incremental (5e1cef12)
• 01: Full - Incremental (7824baa8)
• 00: Full (1adbc9ad)

[andy-goryachev-oracle]

I have a string feeling that this PR should go back to DRAFT state, pending a better listener helper implementation JDK-8294809. Also, this particular skin may need to get it's listeners refactored - I see two scene listeners which seems redundant.

[kleopatra]

I have a string feeling that this PR should go back to DRAFT state, pending a better listener helper implementation JDK-8294809. Also, this particular skin may need to get it's listeners refactored - I see two scene listeners which seems redundant.

don't worry: you choose one of the hardest skins to fix as your first - only the comboXX are worse ;)

• it has OS-specifics
• it needs listeners/handlers on the scene which are very tricky to get right on and off
• it's unusual in not having a behavior (that's where the event handlers should reside)
• it has nested menus (which are problematic in themselves)
• .. probably more :)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[andy-goryachev-oracle]

@hjohn : could you please take a look at this, since it had a non-trivial merge? thanks!

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[andy-goryachev-oracle]

@aghaisas : would you please take a look?

[aghaisas]

Fix looks good to me!

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294589: MenuBarSkin: memory leak when changing skin

Reviewed-by: aghaisas, jhendrikx

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c2af0c3: 8238968: Inconsisent formatting of Rectangle2D toString method
• fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
• 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit 2c18c18.
Since your change was applied there have been 3 commits pushed to the master branch:

• c2af0c3: 8238968: Inconsisent formatting of Rectangle2D toString method
• fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
• 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit 2c18c18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.