-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with continous key press in TextArea and TextField #907
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good, although I think you can avoid redundantly calling getAttribute(TEXT)
by passing in text
as a parameter to validateRange
(see inline comment). Also, for consistency, you might rep,ace the check on lines 236-237 with a call to validateRange
.
modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
Outdated
Show resolved
Hide resolved
@HimaBinduMeda can you be the second reviewer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Exceptions are seen without PR. After applying PR, no exceptions seen. |
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
This is a follow up bug-fix to JDK-8284281
Issue:
When Narrator is running,
Following scenarios with TextField or TextArea cause IllegalArgumentException or NPE
Fix:
Two variable
start
andend
inWinTextRangeProvider
should be validated against text lengthvalidateRange()
, and is called several from methods which access text based onstart
andend
variablesjfx/modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
Line 180 in 35675c8
validateRange()
instead to be symmetrical.Verification:
To observe the issue.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/907/head:pull/907
$ git checkout pull/907
Update a local copy of the PR:
$ git checkout pull/907
$ git pull https://git.openjdk.org/jfx pull/907/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 907
View PR using the GUI difftool:
$ git pr show -t 907
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/907.diff