Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
8233942: Update to 609.1 version of WebKit #91
Updated GTK Webkit 2.26 (609.1) into jfx.
JDK-8233942: Update to 609.1 version of WebKit
A sanity check of the patch looks good to me: I did a build / test on all three platforms. I'll do a bit more testing, and also review the JavaFX-specific files, before completing my review.
To the latter point, I took the patch, applied it to my personal fork, and then split it into two commits, one of which has the changes to the files that I wanted to take a closer look at (finding just those files in the original PR when there are over 5,000 files would be impractical -- impossible given GitHub's 3000 file limitation in the file diff veiwer).
In case this is useful to other reviewers, click here for the diffs. It only includes 87 files, many of which are cmake files for platforms other than
kevinrushforth left a comment
Everything looks good to me.
Here are a couple things I noticed that may warrant a follow-up issue to address them:
@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the
8233942: Update to 609.1 version of WebKit
Co-authored-by: Guru HB <guru.hb at oracle.com>
This message was too large to bridge in full, and has been truncated. Please check the mailing list archive to see the full text.