New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8233942: Update to 609.1 version of WebKit #91
Conversation
👋 Welcome back ghb! A progress list of the required criteria for merging this PR into |
A sanity check of the patch looks good to me: I did a build / test on all three platforms. I'll do a bit more testing, and also review the JavaFX-specific files, before completing my review. To the latter point, I took the patch, applied it to my personal fork, and then split it into two commits, one of which has the changes to the files that I wanted to take a closer look at (finding just those files in the original PR when there are over 5,000 files would be impractical -- impossible given GitHub's 3000 file limitation in the file diff veiwer). In case this is useful to other reviewers, click here for the diffs. It only includes 87 files, many of which are cmake files for platforms other than |
This will need at least two reviewers, including myself and @johanvos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Here are a couple things I noticed that may warrant a follow-up issue to address them:
-
Unimplemented methods:
- FileSystemJava.cpp:
- truncateFile
- MappedFileData::MappedFileData
- MappedFileData::mapFileHandle
- unmapViewOfFile
- FrameLoaderClientJava.cpp:
- didSaveToPageCache
- didRestoreFromPageCache
- FileSystemJava.cpp:
-
General cleanup:
- PageCacheJava.cpp:
// FIXME: Openjfx2.26 rename pagecache to backforwardcache
- PageCacheJava.cpp:
@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the ➡️ To integrate this PR with the above commit message, type |
/contributor (add) Guru HB guru.hb@oracle.com, Arun Joseph <arun.aj.joseph>, Kevin Rushforth kevin.rushforth@oracle.com |
@guruhb Syntax: |
/contributor add Guru HB guru.hb@oracle.com |
@guruhb |
/contributor add Arun Joseph arun.aj.joseph@oracle.com |
@guruhb |
/contributor add Kevin Rushforth kevin.rushforth@oracle.com |
@guruhb |
/integrate |
Mailing list message from Guru Hb on openjfx-dev: Changeset: b2d8564 8233942: Update to 609.1 version of WebKit Co-authored-by: Guru HB <guru.hb at oracle.com> ! modules/javafx.web/src/main/legal/webkit.md This message was too large to bridge in full, and has been truncated. Please check the mailing list archive to see the full text. |
Updated GTK Webkit 2.26 (609.1) into jfx.
Progress
Issue
JDK-8233942: Update to 609.1 version of WebKit
Approvers