Skip to content

8295242: ScrollBarSkin: memory leak when changing skin #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Oct 12, 2022

Fixed memory leak when changing skin in ScrollBarSkin (was adding an event handler without removing it in dispose()).

This change depends on ListenerHelper PR
#908


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295242: ScrollBarSkin: memory leak when changing skin

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/914/head:pull/914
$ git checkout pull/914

Update a local copy of the PR:
$ git checkout pull/914
$ git pull https://git.openjdk.org/jfx pull/914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 914

View PR using the GUI difftool:
$ git pr show -t 914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/914.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Ready for review label Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

@andy-goryachev-oracle
Copy link
Contributor Author

changes will be reviewed as a part of #928

@kevinrushforth kevinrushforth removed the request for review from aghaisas November 28, 2022 21:02
@andy-goryachev-oracle andy-goryachev-oracle deleted the 8295242.scrollbar.skin branch November 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant