-
Notifications
You must be signed in to change notification settings - Fork 506
8295242: ScrollBarSkin: memory leak when changing skin #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295242: ScrollBarSkin: memory leak when changing skin #914
Conversation
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
|
This reverts commit 2df4a85.
changes will be reviewed as a part of #928 |
Fixed memory leak when changing skin in ScrollBarSkin (was adding an event handler without removing it in dispose()).
This change depends on ListenerHelper PR
#908
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/914/head:pull/914
$ git checkout pull/914
Update a local copy of the PR:
$ git checkout pull/914
$ git pull https://git.openjdk.org/jfx pull/914/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 914
View PR using the GUI difftool:
$ git pr show -t 914
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/914.diff