Skip to content

8157224: isNPOTSupported check is too strict#92

Closed
jperedadnr wants to merge 1 commit intoopenjdk:masterfrom
jperedadnr:8157224-ios3D
Closed

8157224: isNPOTSupported check is too strict#92
jperedadnr wants to merge 1 commit intoopenjdk:masterfrom
jperedadnr:8157224-ios3D

Conversation

@jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Jan 23, 2020 •
edited by openjdk bot
Loading

This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, which has (limited) support for npot support.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8157224: isNPOTSupported check is too strict

Approvers

  • Kevin Rushforth (kcr - Reviewer)

@jperedadnr jperedadnr changed the title 8157224 isNPOTSupported check is too strict 8157224: isNPOTSupported check is too strict Jan 23, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2020

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Jan 23, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2020

Webrevs

@openjdk openjdk bot removed the rfr Ready for review label Jan 23, 2020
@openjdk
Copy link

openjdk bot commented Jan 23, 2020 •
edited
Loading

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8157224: isNPOTSupported check is too strict

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jan 23, 2020
@jperedadnr
Copy link
Collaborator Author

jperedadnr commented Jan 23, 2020

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2020

@jperedadnr
Your change (at version 1bef8cf) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor Ready to sponsor label Jan 23, 2020
@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 23, 2020

/sponsor

@openjdk openjdk bot closed this Jan 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated labels Jan 23, 2020
@openjdk
Copy link

openjdk bot commented Jan 23, 2020

@kevinrushforth @jperedadnr
Pushed as commit f5ee963.

@mlbridge
Copy link

mlbridge bot commented Jan 23, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: f5ee963
Author: Jose Pereda <jpereda at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-23 14:36:36 +0000
URL: https://git.openjdk.java.net/jfx/commit/f5ee9631

8157224: isNPOTSupported check is too strict

Reviewed-by: kcr

! modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Pipeline.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jperedadnr @kevinrushforth