8295500: AccordionSkin: memory leak when changing skin

[andy-goryachev-oracle]

as determined by SkinMemoryLeakTest (remove line 164) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.ACCORDION;

caused by:

• adding and not removing listeners

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295500: AccordionSkin: memory leak when changing skin

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/920/head:pull/920
$ git checkout pull/920

Update a local copy of the PR:
$ git checkout pull/920
$ git pull https://git.openjdk.org/jfx pull/920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 920

View PR using the GUI difftool:
$ git pr show -t 920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/920.diff

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[mlbridge]

Webrevs

• 04: Full - Incremental (005ada7f)
• 03: Full (d930b08f)
• 02: Full (8da3b64f)
• 01: Full (218c6ea9)
• 00: Full (513aa910)

[andy-goryachev-oracle]

@aghaisas : would you please review this?

[aghaisas]

Looks good to me!

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295500: AccordionSkin: memory leak when changing skin

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andy-goryachev-oracle]

@aghaisas could you please re-review this PR? I've added some extra comments and whitespace hoping that will avoid further merge conflicts.

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit e64e129.

[openjdk]

@andy-goryachev-oracle Pushed as commit e64e129.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.