Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295531: ComboBoxBaseSkin: memory leak when changing skin #922

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Oct 18, 2022

as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

Affected skins:

  • ColorPicker
  • DatePicker
  • ComboBox

caused by:

  • out-of-order modification of the control property (skin.install)
  • adding skin nodes and not removing them in dispose()
  • adding listeners and not removing them in dispose()

NOTE: the fix will require not only ListenerHelper JDK-8294809 but also Skin.install() JDK-8290844 changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295531: ComboBoxBaseSkin: memory leak when changing skin

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/922/head:pull/922
$ git checkout pull/922

Update a local copy of the PR:
$ git checkout pull/922
$ git pull https://git.openjdk.org/jfx pull/922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 922

View PR using the GUI difftool:
$ git pr show -t 922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/922.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2022

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review November 28, 2022 18:48
@openjdk openjdk bot added the rfr Ready for review label Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

@andy-goryachev-oracle
Copy link
Contributor Author

@aghaisas @hjohn @karthikpandelu could you please review?

Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Looks good to me!

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295531: ComboBoxBaseSkin: memory leak when changing skin

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • bb98d88: 8295806: TableViewSkin: memory leak when changing skin
  • 2c18c18: 8294589: MenuBarSkin: memory leak when changing skin
  • c2af0c3: 8238968: Inconsisent formatting of Rectangle2D toString method
  • fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
  • 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 6, 2022
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit bb13920.
Since your change was applied there have been 7 commits pushed to the master branch:

  • f333662: 8297413: Remove easy warnings in javafx.graphics
  • 7b3c88b: 8295324: JavaFX: Blank pages when printing
  • bb98d88: 8295806: TableViewSkin: memory leak when changing skin
  • 2c18c18: 8294589: MenuBarSkin: memory leak when changing skin
  • c2af0c3: 8238968: Inconsisent formatting of Rectangle2D toString method
  • fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
  • 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@andy-goryachev-oracle Pushed as commit bb13920.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8295531.color.picker.skin branch December 6, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants