8295796: ScrollPaneSkin: memory leak when changing skin

[andy-goryachev-oracle]

as determined by SkinMemoryLeakTest (remove line 174) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

caused by:

• adding and not removing listeners
• adding and not removing event handlers/filters

NOTE:
this fix requires JDK-8295242 scroll bar fixes, as well as JDK-8294809 ListenerHelper

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8295796: ScrollPaneSkin: memory leak when changing skin
• JDK-8295242: ScrollBarSkin: memory leak when changing skin

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/928/head:pull/928
$ git checkout pull/928

Update a local copy of the PR:
$ git checkout pull/928
$ git pull https://git.openjdk.org/jfx pull/928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 928

View PR using the GUI difftool:
$ git pr show -t 928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/928.diff

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[mlbridge]

Webrevs

• 00: Full (3e9678a9)

[andy-goryachev-oracle]

contains changes from #914 so perhaps that should be reviewed/integrated first.

[kevinrushforth]

In that case, you might consider closing PR #914 , and then adding that issue to this PR with /issue add 8295242, so they can be reviewed together?

[andy-goryachev-oracle]

/issue add 8295242

[andy-goryachev-oracle]

/issue add JDK-8295242

[openjdk]

@andy-goryachev-oracle
Adding additional issue to issue list: 8295242: ScrollBarSkin: memory leak when changing skin.

[openjdk]

@andy-goryachev-oracle
Updating description of additional solved issue: 8295242: ScrollBarSkin: memory leak when changing skin.

[aghaisas]

The fix looks good.
I have a cleanup comment on the Test.

[aghaisas]

We can remove these lines instead of commenting them out.

[andy-goryachev-oracle]

@aghaisas :
will clean up this area once the last PR is integrated, otherwise we'll have constant merge conflicts here (every skin memory leak PR touches this)

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295796: ScrollPaneSkin: memory leak when changing skin
8295242: ScrollBarSkin: memory leak when changing skin

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 4ad8582: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest
• d040c1f: 8297680: JavaDoc example for PseudoClass has minor typo

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[andy-goryachev-oracle]

/integrate

[openjdk]

@andy-goryachev-oracle
Your change (at version 3e9678a) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit fbad15d.
Since your change was applied there have been 2 commits pushed to the master branch:

• 4ad8582: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest
• d040c1f: 8297680: JavaDoc example for PseudoClass has minor typo

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @andy-goryachev-oracle Pushed as commit fbad15d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.