8295327: JavaFX - IllegalArgumentException when printing with margins equal to 0 #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If floating point error caused a small negative value in the conversions needed from ISO to US measurements, then this will cause the IAE reported.
The code doing the rounding should not have used Math.abs()
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/934/head:pull/934
$ git checkout pull/934
Update a local copy of the PR:
$ git checkout pull/934
$ git pull https://git.openjdk.org/jfx pull/934/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 934
View PR using the GUI difftool:
$ git pr show -t 934
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/934.diff