Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265835: Exception in Quantum due to null platformWindow #935

Closed
wants to merge 1 commit into from

Conversation

lukostyra
Copy link
Contributor

@lukostyra lukostyra commented Nov 2, 2022

Reproduction code was not provided, I wasn't able to reproduce the circumstances in which the issue occurs. On our side it seems like WindowStage.getPlatformWindow() will not return null, however it is also difficult to reject the possibility that some custom user code might trigger an edge-case where a null will be returned.

Adding these checks is not an intrusive change to our code, it is in fact an extra null-check added to already existing checks, but it might prevent the exception from appearing in the future.

I checked other places in our code using WindowStage.getPlatformWindow() and none require a null check.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265835: Exception in Quantum due to null platformWindow

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/935/head:pull/935
$ git checkout pull/935

Update a local copy of the PR:
$ git checkout pull/935
$ git pull https://git.openjdk.org/jfx pull/935/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 935

View PR using the GUI difftool:
$ git pr show -t 935

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/935.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back lukostyra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Nov 2, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@lukostyra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265835: Exception in Quantum due to null platformWindow

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ac8382b: 8294400: Provide media support for libavcodec version 59
  • 4a2afb4: 8295962: Reference to State in Task.java is ambiguous when building with JDK 19

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Nov 3, 2022
@lukostyra
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@lukostyra
Your change (at version 85253ab) is now ready to be sponsored by a Committer.

@arapte
Copy link
Member

arapte commented Nov 3, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit 01735b3.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 748107a: 8295327: JavaFX - IllegalArgumentException when printing with margins equal to 0
  • ac8382b: 8294400: Provide media support for libavcodec version 59
  • 4a2afb4: 8295962: Reference to State in Task.java is ambiguous when building with JDK 19

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@arapte @lukostyra Pushed as commit 01735b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lukostyra lukostyra deleted the JDK-8265835-Quantum-null branch November 17, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants