Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296330: Tests: Add layout container snapping tests #936

Closed
wants to merge 7 commits into from

Conversation

Maran23
Copy link
Member

@Maran23 Maran23 commented Nov 3, 2022

While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more layout container which do not snap their children correctly.

The goal of this PR is to add snapping tests for all layout container.
After that we can create issues for all broken layout container, fix them and comment in the corresponding line.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296330: Tests: Add layout container snapping tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/936/head:pull/936
$ git checkout pull/936

Update a local copy of the PR:
$ git checkout pull/936
$ git pull https://git.openjdk.org/jfx pull/936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 936

View PR using the GUI difftool:
$ git pr show -t 936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/936.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

@kevinrushforth kevinrushforth requested review from kevinrushforth and arapte and removed request for kevinrushforth November 4, 2022 19:54
@kevinrushforth
Copy link
Member

NOTE: this is blocked by the fix for JDK-8296283, which @arapte plans to do next week.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor questions and suggestions, otherwise looks good.

…ainer on top and renamed ContainerInstruction to ContainerCreator
Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good. Provided with two minor typo corrections and a question.

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296330: Tests: Add layout container snapping tests

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • a13630f: 8268877: TextInputControlSkin: incorrect inputMethod event handler after switching skin
  • 7ec0852: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue
  • 5956950: 8285503: SwingNodeDnDMemoryLeakTest::testSwingNodeMemoryLeak fails sometimes
  • 0ee116d: 8296589: PixelBufferDrawTest fails on some systems
  • 7dc284d: 8221708: Update Eclipse project files
  • f4e27e9: 8222210: JFXPanel popups open at wrong coordinates when using multiple hidpi monitors
  • 706261b: 8296592: Skip failing test StraightLineTest on Linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 16, 2022
@Maran23
Copy link
Member Author

Maran23 commented Nov 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

Going to push as commit 626227d.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 1ec06a8: 8206430: Use consistent pattern for startup in FX system tests
  • 74af45d: 8296556: Mark two RobotTest methods as unstable on HiDPI Windows systems
  • 6cc9c4d: 8297042: gradle -PBUILD_SDK_FOR_TEST=false fails with gradle 7.6
  • a13630f: 8268877: TextInputControlSkin: incorrect inputMethod event handler after switching skin
  • 7ec0852: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue
  • 5956950: 8285503: SwingNodeDnDMemoryLeakTest::testSwingNodeMemoryLeak fails sometimes
  • 0ee116d: 8296589: PixelBufferDrawTest fails on some systems
  • 7dc284d: 8221708: Update Eclipse project files
  • f4e27e9: 8222210: JFXPanel popups open at wrong coordinates when using multiple hidpi monitors
  • 706261b: 8296592: Skip failing test StraightLineTest on Linux

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2022
@openjdk openjdk bot closed this Nov 17, 2022
@openjdk openjdk bot removed the ready Ready to be integrated label Nov 17, 2022
@openjdk openjdk bot removed the rfr Ready for review label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@Maran23 Pushed as commit 626227d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants