-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296330: Tests: Add layout container snapping tests #936
Conversation
👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into |
Webrevs
|
NOTE: this is blocked by the fix for JDK-8296283, which @arapte plans to do next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor questions and suggestions, otherwise looks good.
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
…ainer on top and renamed ContainerInstruction to ContainerCreator
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good. Provided with two minor typo corrections and a question.
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
Show resolved
Hide resolved
@Maran23 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 626227d.
Your commit was automatically rebased without conflicts. |
While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more layout container which do not snap their children correctly.
The goal of this PR is to add snapping tests for all layout container.
After that we can create issues for all broken layout container, fix them and comment in the corresponding line.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/936/head:pull/936
$ git checkout pull/936
Update a local copy of the PR:
$ git checkout pull/936
$ git pull https://git.openjdk.org/jfx pull/936/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 936
View PR using the GUI difftool:
$ git pr show -t 936
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/936.diff