8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

[andy-goryachev-oracle]

• added test to ensure no exception is thrown from Control.queryAccessibleAttribute() for all accessible attributes values
• fixed null focus model case in Tree/TableView

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

Reviewers

• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/938/head:pull/938
$ git checkout pull/938

Update a local copy of the PR:
$ git checkout pull/938
$ git pull https://git.openjdk.org/jfx pull/938/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 938

View PR using the GUI difftool:
$ git pr show -t 938

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/938.diff

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[mlbridge]

Webrevs

• 02: Full - Incremental (f7ecf537)
• 01: Full (6111660b)
• 00: Full (b88d3267)

[arapte]

Looks good to me, one minor change needed in new file to change copyright year to 2023

[arapte]

LGTM

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 94fb7ed: 8216507: StyleablePropertyFactory: example in class javadoc does not compile
• 012fa16: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit e866a6c.
Since your change was applied there have been 3 commits pushed to the master branch:

• 0dbc448: 8231864: JavaFX Labels in Tab's VBox is not displayed until it is clicked
• 94fb7ed: 8216507: StyleablePropertyFactory: example in class javadoc does not compile
• 012fa16: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit e866a6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.