8296283: JUnit5 tests using Params API fails to compile

[arapte]

This issue was uncovered when running the test added in PR: #910
The JUnit5 tests using Params API fails to compile.

Fix:
Change dependency of junit-jupiter-params from runtime to compile time.
From: https://junit.org/junit5/docs/current/user-guide/#overview-what-is-junit-5: it can be understood that packages of JUnit Jupiter other than TestEngine are required for test compilation and
JUnit Platform serves as a foundation for launching testing frameworks

It seems that changing dependency of this one package is sufficient for this fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296283: JUnit5 tests using Params API fails to compile

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Andy Goryachev (@andy-goryachev-oracle - Author) 🔄 Re-review required (review applies to 64ba3a96)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/939/head:pull/939
$ git checkout pull/939

Update a local copy of the PR:
$ git checkout pull/939
$ git pull https://git.openjdk.org/jfx pull/939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 939

View PR using the GUI difftool:
$ git pr show -t 939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/939.diff

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full - Incremental (ff684bec)
• 01: Full - Incremental (64ba3a96)
• 00: Full (5693eba4)

[kevinrushforth]

Looks good, pending my question about junit-platform-commons.

[openjdk]

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296283: JUnit5 tests using Params API fails to compile

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[arapte]

@kevinrushforth
Added a test as you suggested offline.
The checks inside test may not be required, please suggest if any modifications required.

[andy-goryachev-oracle]

We have other tests which use @RunWith(Parameterized.class) just fine (for example, SkinMemoryLeakTest). Is this about mixing junit4 and junit5 classes?

Do we need to make changes in other tests?

[nlisker]

It could be a good idea in a follow-up PR to move the version numbers to a constant so that we don't need to update each separately, like the Junit "5.8.1" version.

[arapte]

We have other tests which use @RunWith(Parameterized.class) just fine (for example, SkinMemoryLeakTest). Is this about mixing junit4 and junit5 classes?

It is not about mixing. The JUnit5 test added in PR #910 which uses annotations from org.junit.jupiter.params failed to compile on my local machine throwing following errors:

error: package org.junit.jupiter.params does not exist
error: package org.junit.jupiter.params.provider does not exist
error: cannot find symbol @ValueSource
error: cannot find symbol @ParameterizedTest 

This PR fixes that compilation error.
I am not sure how it worked on GHA.

Do we need to make changes in other tests?

It won't need any changes in existing tests.

[kevinrushforth]

The test looks good. I left a couple minor comments.

[andy-goryachev-oracle]

thank you for clarifications.

[kevinrushforth]

We have other tests which use @RunWith(Parameterized.class) just fine (for example, SkinMemoryLeakTest). Is this about mixing junit4 and junit5 classes?

Do we need to make changes in other tests?

No, this bug is about specific APIs that are part of the junit-jupiter-params jar file. Specifically, the ValueSource and ParameterizedTest annotations not being available at compile time in all cases. It works accidentally without the build.gradle fix for open builds (e.g., GHA) and fails in our CI build without this change.

[kevinrushforth]

It could be a good idea in a follow-up PR to move the version numbers to a constant so that we don't need to update each separately, like the Junit "5.8.1" version.

Yes, this is a good idea. @arapte can you file a follow-on issue?

[arapte]

/integrate

[openjdk]

Going to push as commit b08f135.

[openjdk]

@arapte Pushed as commit b08f135.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.