Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237823: Mark TextTest.testTabSize as unstable #94

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 24, 2020

Fix for JDK-8237823.

The javafx.graphics unit test TextTest.testTabSize fails intermittently -- see JDK-8236728.

This PR marks TextTest.testTabSize as unstable, meaning it will not be run by default. It will be run only when running gradle with the -PUNSTABLE_TEST=true flag.

As noted in the bug report, I see this about 20% of the time in our nightly and CI builds. Given that we are getting late in the cycle for openjfx14, we need to mark the test as unstable until a fix can be found.

NOTE: this is targeted to jfx14.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237823: Mark TextTest.testTabSize as unstable

Approvers

  • Phil Race (prr - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Jan 24, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 24, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 24, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jan 24, 2020

@prrace can you review this?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Webrevs

prrace
prrace approved these changes Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237823: Mark TextTest.testTabSize as unstable

Reviewed-by: prr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 24, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jan 24, 2020

/integrate

@openjdk openjdk bot closed this Jan 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@kevinrushforth
Pushed as commit da99e24.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: da99e24
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-24 16:54:57 +0000
URL: https://git.openjdk.java.net/jfx/commit/da99e248

8237823: Mark TextTest.testTabSize as unstable

Reviewed-by: prr

! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: da99e24
Author: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-24 16:54:57 +0000
URL: https://git.openjdk.java.net/jfx/commit/da99e248

8237823: Mark TextTest.testTabSize as unstable

Reviewed-by: prr

! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java

@kevinrushforth kevinrushforth deleted the 8237823-unstable-test branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants