Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8237782: Only read advances up to the minimum of the numHorMetrics or the available font data. #95

Closed
wants to merge 1 commit into from
Closed

8237782: Only read advances up to the minimum of the numHorMetrics or the available font data. #95

wants to merge 1 commit into from

Conversation

prrace
Copy link
Collaborator

@prrace prrace commented Jan 24, 2020 •
edited by openjdk bot

… the available font data.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.

Approvers

  • Kevin Rushforth (kcr - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Jan 24, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2020

Webrevs

@kevinrushforth kevinrushforth changed the title 8237782: Only read advances up to the minimum of the numHorMetrics or… Only read advances up to the minimum of the numHorMetrics or the available font data. Jan 31, 2020
@kevinrushforth
Copy link
Member

Looks like GitHub truncated your title, so I fixed it to match the JBS title.

@openjdk openjdk bot removed the rfr Ready for review label Jan 31, 2020
@kevinrushforth kevinrushforth changed the title Only read advances up to the minimum of the numHorMetrics or the available font data. 8237782: Only read advances up to the minimum of the numHorMetrics or the available font data. Jan 31, 2020
@openjdk openjdk bot added the rfr Ready for review label Jan 31, 2020
kevinrushforth
kevinrushforth approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 31, 2020 •
edited

@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 14 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 95bf2c006a5b105fba0a33543f3ec096a9e45a74.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 31, 2020
@prrace
Copy link
Collaborator Author

prrace commented Jan 31, 2020

/integrate

@openjdk openjdk bot closed this Jan 31, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jan 31, 2020
@openjdk
Copy link

openjdk bot commented Jan 31, 2020

@prrace The following commits have been pushed to master since your change was applied:

  • d05e8fc: 8237833: Check glyph size before adding to glyph texture cache
  • 1213ea7: Merge
  • 1823f6e: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
  • ca37c1f: 8238249: GetPrimitiveArrayCritical passed with hardcoded FALSE value
  • b96bc52: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
  • d303a21: Merge
  • 5a0e71b: 8237372: NullPointerException in TabPaneSkin.stopDrag
  • 79fc0d0: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one
  • aa6f3a4: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
  • 921389f: Merge
  • da99e24: 8237823: Mark TextTest.testTabSize as unstable
  • 66ac99f: Merge
  • 9ae37f1: 8236753: Animations do not play backwards after being stopped

Your commit was automatically rebased without conflicts.

Pushed as commit 95bf2c0.

@mlbridge
Copy link

mlbridge bot commented Jan 31, 2020

Mailing list message from Phil Race on openjfx-dev:

Changeset: 95bf2c0
Author: Phil Race <prr at openjdk.org>
Date: 2020-01-31 18:22:52 +0000
URL: https://git.openjdk.java.net/jfx/commit/95bf2c00

8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.

Reviewed-by: kcr

! modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java

@prrace prrace deleted the htmx_fix branch February 3, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

Assignees

@prrace prrace

Labels
integrated Pull request has been integrated
Milestone
No milestone
2 participants
@prrace @kevinrushforth