-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297166: [TestBug] Fix some ignored unit test from TableViewTest #952
8297166: [TestBug] Fix some ignored unit test from TableViewTest #952
Conversation
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java
Show resolved
Hide resolved
@@ -2047,8 +2051,12 @@ public TableCell<Person, String> call(TableColumn<Person, String> p) { | |||
sl.dispose(); | |||
} | |||
|
|||
// @Ignore("Test started intermittently failing, most probably due to RT-36855 changeset") | |||
@Test public void test_rt_34493() { | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comment. If needed, we can get this information from looking at file revision history.
@andy-goryachev-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@andy-goryachev-oracle |
/sponsor |
Going to push as commit e3e0dfd.
Your commit was automatically rebased without conflicts. |
@kevinrushforth @andy-goryachev-oracle Pushed as commit e3e0dfd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Re-enabled some ignored tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/952/head:pull/952
$ git checkout pull/952
Update a local copy of the PR:
$ git checkout pull/952
$ git pull https://git.openjdk.org/jfx pull/952/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 952
View PR using the GUI difftool:
$ git pr show -t 952
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/952.diff