8237833: Check glyph size before adding to glyph texture cache

[prrace]

Check if the glyph will fit before trying to cache it.

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

JDK-8237833: Check glyph size before adding to glyph texture cache.

Approvers

• Kevin Rushforth (kcr - Reviewer)

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 00: Full (fbfb247)

[kevinrushforth]

Looks good.

[openjdk]

@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237833: Check glyph size before adding to glyph texture cache

Reviewed-by: kcr

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 13 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d05e8fc43d0957d0880913714e70c4f9244f36d2.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

@prrace The following commits have been pushed to master since your change was applied:

• 1213ea7: Merge
• 1823f6e: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
• ca37c1f: 8238249: GetPrimitiveArrayCritical passed with hardcoded FALSE value
• b96bc52: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
• d303a21: Merge
• 5a0e71b: 8237372: NullPointerException in TabPaneSkin.stopDrag
• 79fc0d0: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one
• aa6f3a4: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
• 921389f: Merge
• da99e24: 8237823: Mark TextTest.testTabSize as unstable
• 66ac99f: Merge
• 9ae37f1: 8236753: Animations do not play backwards after being stopped

Your commit was automatically rebased without conflicts.

Pushed as commit d05e8fc.

[mlbridge]

Mailing list message from Phil Race on openjfx-dev:

Changeset: d05e8fc
Author: Phil Race <prr at openjdk.org>
Date: 2020-01-31 18:21:51 +0000
URL: https://git.openjdk.java.net/jfx/commit/d05e8fc4

8237833: Check glyph size before adding to glyph texture cache

Reviewed-by: kcr

! modules/javafx.graphics/src/main/java/com/sun/prism/impl/GlyphCache.java