8297362: EOS might not be delivered by progressbuffer in some cases

[sashamatveev]

This is regression from JDK-8043352. JDK-8043352 moved clearing pending events in progress buffer when upstream sends EOS. We need to do this for any other events except EOS. If we clear pending EOS, then it will not be delivered and we will hang due to downstream waiting for data or EOS. We still need to clear any other events such as new segment and not deliver it once we receive EOS.

Added "plugins" folder to macOS project. For some reason it was missing and debugging plugins with xcode was not possible.

Tested on all platforms with all formats over FILE and HTTP protocol. EOS was delivered correctly in all cases.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8297362: EOS might not be delivered by progressbuffer in some cases

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/961/head:pull/961
$ git checkout pull/961

Update a local copy of the PR:
$ git checkout pull/961
$ git pull https://git.openjdk.org/jfx pull/961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 961

View PR using the GUI difftool:
$ git pr show -t 961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/961.diff

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (a17c70c4)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

Looks good.

[arapte]

Looks good to me too.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297362: EOS might not be delivered by progressbuffer in some cases

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• cce8580: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used
• a0ea874: 8279214: Memory leak in Scene after dragging a cell
• 9819d45: 8297332: Remove easy warnings in javafx.base
• 086dac0: 8297213: Robot capture tests should move mouse to corner of screen
• e3e0dfd: 8297166: [TestBug] Fix some ignored unit test from TableViewTest
• 626227d: 8296330: Tests: Add layout container snapping tests
• 1ec06a8: 8206430: Use consistent pattern for startup in FX system tests
• 74af45d: 8296556: Mark two RobotTest methods as unstable on HiDPI Windows systems
• 6cc9c4d: 8297042: gradle -PBUILD_SDK_FOR_TEST=false fails with gradle 7.6
• a13630f: 8268877: TextInputControlSkin: incorrect inputMethod event handler after switching skin
• ... and 7 more: https://git.openjdk.org/jfx/compare/7f17447aa44fbf5b09aaa2b699266dac8b50cea1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

Going to push as commit 9416874.
Since your change was applied there have been 29 commits pushed to the master branch:

• e64e129: 8295500: AccordionSkin: memory leak when changing skin
• 6ab65a9: 8295506: ButtonBarSkin: memory leak when changing skin
• 4a19fe7: 8295426: MenuButtonSkin: memory leak when changing skin
• 0a785ae: 8295754: PaginationSkin: memory leak when changing skin
• 2fa9f4b: 8297414: Remove easy warnings in javafx.controls
• 7cb408b: 8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web
• fbad15d: 8295796: ScrollPaneSkin: memory leak when changing skin
• 4ad8582: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest
• d040c1f: 8297680: JavaDoc example for PseudoClass has minor typo
• 3376228: 8294809: ListenerHelper for managing and disconnecting listeners
• ... and 19 more: https://git.openjdk.org/jfx/compare/7f17447aa44fbf5b09aaa2b699266dac8b50cea1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit 9416874.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.