Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238968: Inconsisent formatting of Rectangle2D toString method #967

Closed

Conversation

lukostyra
Copy link
Contributor

@lukostyra lukostyra commented Dec 5, 2022

The string was fixed to match other parameters' formatting.

There was a PR submitted for this change a long time ago, but there were some issue with its previous author. Today I found the issue being assigned to me, so I figured I might as well submit a patch for it as it was a quick & easy fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8238968: Inconsisent formatting of Rectangle2D toString method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/967/head:pull/967
$ git checkout pull/967

Update a local copy of the PR:
$ git checkout pull/967
$ git pull https://git.openjdk.org/jfx pull/967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 967

View PR using the GUI difftool:
$ git pr show -t 967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/967.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back lkostyra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

Copy link
Collaborator

@nlisker nlisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A trivial fix that was proposed in #88. One reviewer is enough.

This is a case where a record would have been best.

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@lukostyra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8238968: Inconsisent formatting of Rectangle2D toString method

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
  • 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases
  • e64e129: 8295500: AccordionSkin: memory leak when changing skin
  • 6ab65a9: 8295506: ButtonBarSkin: memory leak when changing skin
  • 4a19fe7: 8295426: MenuButtonSkin: memory leak when changing skin
  • 0a785ae: 8295754: PaginationSkin: memory leak when changing skin
  • 2fa9f4b: 8297414: Remove easy warnings in javafx.controls

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Dec 5, 2022
@lukostyra
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@lukostyra
Your change (at version e530612) is now ready to be sponsored by a Committer.

@nlisker
Copy link
Collaborator

nlisker commented Dec 5, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

Going to push as commit c2af0c3.
Since your change was applied there have been 7 commits pushed to the master branch:

  • fe81a27: 8287822: [macos] Remove support of duplicated formats from macOS
  • 9416874: 8297362: EOS might not be delivered by progressbuffer in some cases
  • e64e129: 8295500: AccordionSkin: memory leak when changing skin
  • 6ab65a9: 8295506: ButtonBarSkin: memory leak when changing skin
  • 4a19fe7: 8295426: MenuButtonSkin: memory leak when changing skin
  • 0a785ae: 8295754: PaginationSkin: memory leak when changing skin
  • 2fa9f4b: 8297414: Remove easy warnings in javafx.controls

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2022
@openjdk openjdk bot closed this Dec 5, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@nlisker @lukostyra Pushed as commit c2af0c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lukostyra lukostyra deleted the JDK-8238968-string-formatting branch December 5, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants