-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8238968: Inconsisent formatting of Rectangle2D toString method #967
Conversation
👋 Welcome back lkostyra! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A trivial fix that was proposed in #88. One reviewer is enough.
This is a case where a record
would have been best.
@lukostyra This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@lukostyra |
/sponsor |
Going to push as commit c2af0c3.
Your commit was automatically rebased without conflicts. |
@nlisker @lukostyra Pushed as commit c2af0c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The string was fixed to match other parameters' formatting.
There was a PR submitted for this change a long time ago, but there were some issue with its previous author. Today I found the issue being assigned to me, so I figured I might as well submit a patch for it as it was a quick & easy fix.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/967/head:pull/967
$ git checkout pull/967
Update a local copy of the PR:
$ git checkout pull/967
$ git pull https://git.openjdk.org/jfx pull/967/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 967
View PR using the GUI difftool:
$ git pr show -t 967
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/967.diff