Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237944: webview native cl "-m32" unknown option for windows 32-bit build #97

Closed
wants to merge 2 commits into from

Conversation

@guruhb
Copy link
Contributor

guruhb commented Jan 28, 2020

cl : Command line warning D9002 : ignoring unknown option '-m32'

post fix for "https://trac.webkit.org/changeset/242724/webkit" makes use of cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
'-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't recognize this flag.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8237944: webview native cl "-m32" unknown option for windows 32-bit build

Approvers

  • Kevin Rushforth (kcr - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@guruhb guruhb requested a review from kevinrushforth Jan 28, 2020
@openjdk openjdk bot added the rfr label Jan 28, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2020

Webrevs

@johanvos
Copy link
Collaborator

johanvos commented Jan 28, 2020

the -m32 option seems to be ignored by the compiler:
cl : Command line warning D9002 : ignoring unknown option '-m32'

However, I agree it is better to conditionally remove it.

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 28, 2020

Agreed. It's a good cleanup fix. I'll do a quick test and then review it.

Copy link
Member

kevinrushforth left a comment

All my testing looks good. I added one comment for you to take a look at.

@openjdk
Copy link

openjdk bot commented Jan 29, 2020

@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237944: webview native cl "-m32" unknown option for windows 32-bit build

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 56267e1ffb51037f0a1050c5fd1e51c2ee555c07.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2020
@guruhb
Copy link
Contributor Author

guruhb commented Jan 29, 2020

the -m32 option seems to be ignored by the compiler:
cl : Command line warning D9002 : ignoring unknown option '-m32'

However, I agree it is better to conditionally remove it.
"-m32" required for compiling other ports of webkit (WebkitGTK, WPE) and for our platform I haven't tested this feature (i.e cross compiling on a 64 bit Linux).

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 31, 2020

@guruhb this is ready to integrate unless @johanvos wants to review it.

@guruhb
Copy link
Contributor Author

guruhb commented Feb 3, 2020

/integrate

@openjdk openjdk bot closed this Feb 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 3, 2020
@openjdk
Copy link

openjdk bot commented Feb 3, 2020

@guruhb The following commits have been pushed to master since your change was applied:

  • 56267e1: 8237770: Error creating fragment phong shader on iOS
  • 95bf2c0: 8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.
  • d05e8fc: 8237833: Check glyph size before adding to glyph texture cache
  • 1213ea7: Merge
  • 1823f6e: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
  • ca37c1f: 8238249: GetPrimitiveArrayCritical passed with hardcoded FALSE value
  • b96bc52: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
  • d303a21: Merge
  • 5a0e71b: 8237372: NullPointerException in TabPaneSkin.stopDrag
  • 79fc0d0: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one
  • aa6f3a4: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

Your commit was automatically rebased without conflicts.

Pushed as commit aa91ebb.

@openjdk openjdk bot removed the rfr label Feb 3, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2020

Mailing list message from Guru Hb on openjfx-dev:

Changeset: aa91ebb
Author: Guru Hb <ghb at openjdk.org>
Date: 2020-02-03 08:51:25 +0000
URL: https://git.openjdk.java.net/jfx/commit/aa91ebbb

8237944: webview native cl "-m32" unknown option for windows 32-bit build

Reviewed-by: kcr

! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.