Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297067: Update Gradle to 7.6 #973

Closed
wants to merge 3 commits into from
Closed

Conversation

arapte
Copy link
Member

@arapte arapte commented Dec 14, 2022

This upgrades gradle to 7.6, It is blocker for upgrading Boot JDK to 19.
gradle 7.3 does not support JDK 19.
Tested that, gradle 7.6 works with JDK 17, 18, 19.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/973/head:pull/973
$ git checkout pull/973

Update a local copy of the PR:
$ git checkout pull/973
$ git pull https://git.openjdk.org/jfx pull/973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 973

View PR using the GUI difftool:
$ git pr show -t 973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/973.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@arapte arapte marked this pull request as ready for review December 14, 2022 15:20
@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk openjdk bot added the rfr Ready for review label Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johanvos or @tiainen can one of you be the second reviewer?

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, this is a much-needed update!

@openjdk
Copy link

openjdk bot commented Dec 17, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297067: Update Gradle to 7.6

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 30147d2: 8298496: IconifyTest fails intermittently on Linux
  • 58376eb: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting
  • adfc022: 8290040: Provide simplified deterministic way to manage listeners
  • f217d5e: 8298200: Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.*

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 17, 2022
@arapte
Copy link
Member Author

arapte commented Dec 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

Going to push as commit ae86ed3.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 30147d2: 8298496: IconifyTest fails intermittently on Linux
  • 58376eb: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting
  • adfc022: 8290040: Provide simplified deterministic way to manage listeners
  • f217d5e: 8298200: Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.*

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2022
@openjdk openjdk bot closed this Dec 19, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@arapte Pushed as commit ae86ed3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the gradle-7.6 branch February 2, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants