-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297067: Update Gradle to 7.6 #973
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, this is a much-needed update!
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ae86ed3.
Your commit was automatically rebased without conflicts. |
This upgrades gradle to 7.6, It is blocker for upgrading Boot JDK to 19.
gradle 7.3 does not support JDK 19.
Tested that, gradle 7.6 works with JDK 17, 18, 19.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/973/head:pull/973
$ git checkout pull/973
Update a local copy of the PR:
$ git checkout pull/973
$ git pull https://git.openjdk.org/jfx pull/973/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 973
View PR using the GUI difftool:
$ git pr show -t 973
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/973.diff