Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298496: IconifyTest fails intermittently on Linux #975

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 14, 2022

IconifyTest is unstable on Linux, which makes it impossible to rely on it to test the ability to iconify and deiconify a Stage. The reason for the instability is that the stacking order of multiple always-on-top windows on Linux is wrong sometimes. See JDK-8298499. Using two always-on-top Stages is unnecessary for this test, and the test will be more stable without it. The fix is to create the bottom Stage without setting alwaysOnTop, leaving only the top Stage alwaysOnTop. Further, the test now waits for the bottom Stage to be shown before creating the top Stage. The call to topStage.toFront() is removed as it is unnecessary. It should never have been needed, and its presence suggests that it might have been an attempted workaround for the stacking order problem (now tracked by JDK-8298499 as mentioned previously). Finally, I increased the wait time between operations from 500 msec to 1000 msec, to match what most other similar tests do (this latter helped stability on my old Ubuntu 16.04 system).

With this fix, the test is now stable on Linux (and is still stable on Windows and Mac). It consistently passes on Linux except Ubuntu 22.04, where it now shows a real problem that undecorated/transparent Stages consistently fail to deiconify (the instability of the test was preventing our being able to see that). Given that #915 fixes this newly discovered problem, I won't file a new bug, but rather will add it to that bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298496: IconifyTest fails intermittently on Linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/975/head:pull/975
$ git checkout pull/975

Update a local copy of the PR:
$ git checkout pull/975
$ git pull https://git.openjdk.org/jfx pull/975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 975

View PR using the GUI difftool:
$ git pr show -t 975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/975.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298496: IconifyTest fails intermittently on Linux

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • adfc022: 8290040: Provide simplified deterministic way to manage listeners
  • f217d5e: 8298200: Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.*

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 15, 2022
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

Going to push as commit 30147d2.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 58376eb: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting
  • adfc022: 8290040: Provide simplified deterministic way to manage listeners
  • f217d5e: 8298200: Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.*

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2022
@openjdk openjdk bot closed this Dec 15, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@kevinrushforth Pushed as commit 30147d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8298496-IconifyTest branch December 22, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants