Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298167: Opacity in WebView not working anymore #992

Closed
wants to merge 4 commits into from

Conversation

wkia
Copy link

@wkia wkia commented Jan 11, 2023

There was refactoring in WebKit's GraphicsContext class (nativecode) WebKit/WebKit@1733b8b

GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't adapted after GraphicsContext's refactoring integration into JFX. As the result, the methods were not invoked, so TransparencyLayer couldn't be added to a rendering queue.

Now the methods are fixed to be used properly in GraphicsContext inheritance chain.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/992/head:pull/992
$ git checkout pull/992

Update a local copy of the PR:
$ git checkout pull/992
$ git pull https://git.openjdk.org/jfx pull/992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 992

View PR using the GUI difftool:
$ git pr show -t 992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/992.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@wkia
Copy link
Author

wkia commented Jan 11, 2023

force-pushed to trigger the tests.

@kevinrushforth
Copy link
Member

This would be good to get into JavaFX 20 (although time is short). It will need a second reviewer.

/reviewers 2

@kevinrushforth
Copy link
Member

force-pushed to trigger the tests.

In the future, you can just push an empty commit.

@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

@jaybhaskar Can you also take a look? This might cause a merge conflict with the in-progress WebKit 615.1 update, but since this is a very targeted patch, I expect it would be an easy conflict to resolve, if it does.

@jaybhaskar
Copy link
Member

The patch looks ok, as [GraphicsContextJava.h] needs to inherit methods from GraphicsContext.h , the begin/endPlatformTransparencyLayers already modified in latest update. so it looks like there would not be conflict.

@kevinrushforth
Copy link
Member

@jaybhaskar Can you also take a look? This might cause a merge conflict with the in-progress WebKit 615.1 update, but since this is a very targeted patch, I expect it would be an easy conflict to resolve, if it does.

I did a quick test, and confirmed that this does fix the problem. I also confirmed that there will be no merge conflict with WebKit 615.1.

@wkia Would it be possible to provide a unit test that fails before and passes after this fix?

Copy link
Member

@jaybhaskar jaybhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+looks good to me

@wkia
Copy link
Author

wkia commented Jan 11, 2023

@wkia Would it be possible to provide a unit test that fails before and passes after this fix?

@kevinrushforth I will try, I guess it will take time.

@kevinrushforth
Copy link
Member

@wkia Would it be possible to provide a unit test that fails before and passes after this fix?

@kevinrushforth I will try, I guess it will take time.

If it ends up being too difficult or time-consuming, it could be done in a follow-up issue. This is a safe and obvious fix, so the main reason for wanting it is to ensure that we don't regress again in the future.

@Schmidor
Copy link
Contributor

There is a small test in the ticket description that I've added to modules\javafx.web\src\test\java\test\javafx\scene\web\SVGTest.java when I tried to track down the problem. Maybe that is enough?

@kevinrushforth
Copy link
Member

I might add it elsewhere (either to a different test class or as a new test class), since it really isn't related to SVG rendering, but yes, something like this would be sufficient.

@wkia
Copy link
Author

wkia commented Jan 11, 2023

@kevinrushforth @Schmidor Test added
I'm not sure about comparing against GRAY and WHITE with 1% tolerance.
It seems OK on my Win11.
Is it ok or should be changed?

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can confirm that the newly added test fails without the fix and passes with the fix. I ran a CI test build on all three platforms and it passes on all of them.

@kevinrushforth
Copy link
Member

@jaybhaskar Can you re-review (the only change since you reviewed was the addition of the unit test)

@wkia wkia requested review from jaybhaskar and removed request for arapte January 12, 2023 07:51
Copy link
Member

@jaybhaskar jaybhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is ok, others files reviewed

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298167: Opacity in WebView not working anymore

Reviewed-by: jbhaskar, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jan 12, 2023
@wkia
Copy link
Author

wkia commented Jan 12, 2023

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@wkia
Your change (at version 9eb388c) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 8136b11.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@kevinrushforth @wkia Pushed as commit 8136b11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the fix-jdk-8298167 branch January 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants