Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299595: Remove terminally deprecated JavaFX GTK 2 library #999

Closed
wants to merge 49 commits into from

Conversation

tsayao
Copy link
Collaborator

@tsayao tsayao commented Jan 17, 2023

Simple PR to remove gtk2 library compilation and loading.


Progress

  • Change requires CSR request JDK-8303493 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8299595: Remove terminally deprecated JavaFX GTK 2 library
  • JDK-8303493: Remove terminally deprecated JavaFX GTK 2 library (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/999/head:pull/999
$ git checkout pull/999

Update a local copy of the PR:
$ git checkout pull/999
$ git pull https://git.openjdk.org/jfx.git pull/999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 999

View PR using the GUI difftool:
$ git pr show -t 999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/999.diff

tsayao and others added 28 commits January 23, 2020 08:44
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2023

👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@johanvos
Copy link
Collaborator

johanvos commented Mar 2, 2023

I was probably a bit too verbose in my comment. Kevin is correct, I only recommended a change (addition) in the text for the warning. Hence, if you revert your latest commit and then apply the textual diff Kevin recommends, we're good.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

@tsayao
Copy link
Collaborator Author

tsayao commented Mar 2, 2023

I'll update the CSR

@tsayao
Copy link
Collaborator Author

tsayao commented Mar 2, 2023

@kevinrushforth
Copy link
Member

CSR: https://bugs.openjdk.org/browse/JDK-8303493

This is ready to move to "Proposed" now. I left a couple minor comments that will need to be addressed before I formally review it and before it is "Finalized".

@tsayao
Copy link
Collaborator Author

tsayao commented Mar 6, 2023

Will do it in a few days.

@kevinrushforth
Copy link
Member

@tsayao The CSR is now approved, but the bot doesn't seem to think so. This is an oddity in the current behavior that I'm discussing with the Skara bot maintainers. Depending on the outcome, it might be necessary for you to merge your PR branch with the latest master to remedy it, but before you do that -- which would then require myself and Johan to re-review the PR -- let's wait another day.

@kevinrushforth
Copy link
Member

@tsayao After discussion with the Skara bot maintainers, the conclusion is that you will need to merge the latest upstream master into your branch in order for the bot to unblock this. The current situation isn't ideal, but there isn't a quick solution in the bot (and I don't want to work around it by removing the requirement for a CSR, since it isn't that urgent to get this integrated).

@johanvos and I will need to do a quick re-review once you merge from master.

@tsayao
Copy link
Collaborator Author

tsayao commented Mar 22, 2023

No problem. Merged from master.

@openjdk openjdk bot removed the csr Need approved CSR to integrate pull request label Mar 22, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@tsayao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299595: Remove terminally deprecated JavaFX GTK 2 library

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 23, 2023
@tsayao
Copy link
Collaborator Author

tsayao commented Mar 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

Going to push as commit 63635ee.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2023
@openjdk openjdk bot closed this Mar 23, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 23, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@tsayao Pushed as commit 63635ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants