8299595: Remove terminally deprecated JavaFX GTK 2 library

[tsayao]

Simple PR to remove gtk2 library compilation and loading.

---

Progress

• Change requires CSR request JDK-8303493 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

• JDK-8299595: Remove terminally deprecated JavaFX GTK 2 library
• JDK-8303493: Remove terminally deprecated JavaFX GTK 2 library (CSR)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/999/head:pull/999
$ git checkout pull/999

Update a local copy of the PR:
$ git checkout pull/999
$ git pull https://git.openjdk.org/jfx.git pull/999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 999

View PR using the GUI difftool:
$ git pr show -t 999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/999.diff

[bridgekeeper]

👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[johanvos]

I was probably a bit too verbose in my comment. Kevin is correct, I only recommended a change (addition) in the text for the warning. Hence, if you revert your latest commit and then apply the textual diff Kevin recommends, we're good.

[kevinrushforth]

Looks good.

[johanvos]

All good now.

[tsayao]

I'll update the CSR

[tsayao]

CSR: https://bugs.openjdk.org/browse/JDK-8303493

[kevinrushforth]

CSR: https://bugs.openjdk.org/browse/JDK-8303493

This is ready to move to "Proposed" now. I left a couple minor comments that will need to be addressed before I formally review it and before it is "Finalized".

[tsayao]

Will do it in a few days.

[kevinrushforth]

@tsayao The CSR is now approved, but the bot doesn't seem to think so. This is an oddity in the current behavior that I'm discussing with the Skara bot maintainers. Depending on the outcome, it might be necessary for you to merge your PR branch with the latest master to remedy it, but before you do that -- which would then require myself and Johan to re-review the PR -- let's wait another day.

[kevinrushforth]

@tsayao After discussion with the Skara bot maintainers, the conclusion is that you will need to merge the latest upstream master into your branch in order for the bot to unblock this. The current situation isn't ideal, but there isn't a quick solution in the bot (and I don't want to work around it by removing the requirement for a CSR, since it isn't that urgent to get this integrated).

@johanvos and I will need to do a quick re-review once you merge from master.

[tsayao]

No problem. Merged from master.

[openjdk]

@tsayao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299595: Remove terminally deprecated JavaFX GTK 2 library

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tsayao]

/integrate

[openjdk]

Going to push as commit 63635ee.

[openjdk]

@tsayao Pushed as commit 63635ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.