Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
/ jfx11u Public archive

8284676: TreeTableView loses sort ordering when applied on empty table #108

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 17, 2022

Clean backport to jfx11u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284676: TreeTableView loses sort ordering when applied on empty table

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx11u pull/108/head:pull/108
$ git checkout pull/108

Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.org/jfx11u pull/108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 108

View PR using the GUI difftool:
$ git pr show -t 108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx11u/pull/108.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0132ac89033334ec9d9ec6149d116e8c352f89ec 8284676: TreeTableView loses sort ordering when applied on empty table Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284676: TreeTableView loses sort ordering when applied on empty table

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Aug 17, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2022

Webrevs

@arapte
Copy link
Member Author

arapte commented Aug 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

Going to push as commit 190dddf.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 19268eb: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
  • d3e8fe1: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255
  • 24e053b: 8088420: JavaFX WebView memory leak via EventListener
  • dd35815: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2022
@openjdk openjdk bot closed this Aug 17, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@arapte Pushed as commit 190dddf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the 8284676 branch August 17, 2022 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant